From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1C5321A1DF6 for ; Wed, 7 Sep 2016 10:38:31 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP; 07 Sep 2016 10:38:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,296,1470726000"; d="scan'208";a="165502727" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 07 Sep 2016 10:38:31 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 7 Sep 2016 10:38:30 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.39]) by FMSMSX119.amr.corp.intel.com ([10.18.124.207]) with mapi id 14.03.0248.002; Wed, 7 Sep 2016 10:38:30 -0700 From: "Carsey, Jaben" To: Abdul Lateef Attar , "edk2-devel@lists.01.org" CC: "Carsey, Jaben" Thread-Topic: [edk2] [PATCH] ShellPkg: pci -i -_e to print next capability Thread-Index: AQHSCAjF+6Kab+kgvk2BUbGUM0mgjaBuTRIw Date: Wed, 7 Sep 2016 17:38:29 +0000 Message-ID: References: <3ac3b70ae8a01c19a82b09787879b351b71d4763.1472819042.git.abdul-lateef.attar@hpe.com> In-Reply-To: <3ac3b70ae8a01c19a82b09787879b351b71d4763.1472819042.git.abdul-lateef.attar@hpe.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2QyN2YyNjgtNWM0Yi00NTAwLWEyZjQtMDdlYjE3NmI5ZDM2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImdlaDlPRzNoYjI2a0ZiWDF1REFhWnVkTmxvVEs3WjczWGp3RWFESXhubHM9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg: pci -i -_e to print next capability X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Sep 2016 17:38:31 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Change Looks good. Can you please clarify the commit message on why to chan= ge -_e type? Reviewed-by: Jaben Carsey > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Abdul Lateef Attar > Sent: Monday, September 05, 2016 11:34 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH] ShellPkg: pci -i -_e to print next capability > Importance: High >=20 > According to PCI spec the next AER capability is relative to > the beginning of PCI configuration space. Hence substract the > base offset to get the next capability. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Abdul Lateef Attar > --- > ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > index 337495e..664c22b 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > @@ -2370,7 +2370,7 @@ PCI_CONFIG_SPACE *mConfigSpace =3D NULL; > STATIC CONST SHELL_PARAM_ITEM ParamList[] =3D { > {L"-s", TypeValue}, > {L"-i", TypeFlag}, > - {L"-_e", TypeFlag}, > + {L"-_e", TypeValue}, > {NULL, TypeMax} > }; >=20 > @@ -5914,7 +5914,7 @@ PciExplainPciExpress ( > // Advance to the next item if it exists > // > if (ExtHdr->NextCapabilityOffset !=3D 0) { > - ExtHdr =3D (PCI_EXP_EXT_HDR*)((UINT8*)ExRegBuffer + ExtHdr- > >NextCapabilityOffset); > + ExtHdr =3D (PCI_EXP_EXT_HDR*)((UINT8*)ExRegBuffer + ExtHdr- > >NextCapabilityOffset - EFI_PCIE_CAPABILITY_BASE_OFFSET); > } else { > break; > } > -- > 2.7.4 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel