From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 73C5F1A1E92 for ; Thu, 22 Sep 2016 09:20:43 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP; 22 Sep 2016 09:20:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,379,1470726000"; d="scan'208";a="12610592" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 22 Sep 2016 09:20:42 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 22 Sep 2016 09:20:42 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.80]) by FMSMSX110.amr.corp.intel.com ([169.254.14.41]) with mapi id 14.03.0248.002; Thu, 22 Sep 2016 09:20:42 -0700 From: "Carsey, Jaben" To: Tapan Shah , "edk2-devel@lists.01.org" CC: "Carsey, Jaben" Thread-Topic: [PATCH] ShellPkg: Expand special output file to include "NULL" and case insensitive Thread-Index: AQHSFOxgmQdbu3kBEE2wI6Nv8vEGVKCFsCKQ Date: Thu, 22 Sep 2016 16:20:41 +0000 Message-ID: References: <1474560837-10660-1-git-send-email-tapandshah@hpe.com> In-Reply-To: <1474560837-10660-1-git-send-email-tapandshah@hpe.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMThiZWRmZjctYmQ3Ni00MjJkLWFlMDgtMzE4ZjRjMzI0YTA0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InNleU52WUF5V3hnNE9PN0dXTVJRdmptbmpycStGNStEWkRCajROT0JrRUk9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg: Expand special output file to include "NULL" and case insensitive X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Sep 2016 16:20:43 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Tapan, I do not think we should tie UefiShellLib into UefiShellCommandLib. The pr= oblem is that UefiShellLib is for internal commands, the shell itself, and = shell applications. The UefiShellCommandLib is only for internal commands.= What amount of work would it take to keep these libraries separate? -Jaben > -----Original Message----- > From: Tapan Shah [mailto:tapandshah@hpe.com] > Sent: Thursday, September 22, 2016 9:14 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Tapan Shah > > Subject: [PATCH] ShellPkg: Expand special output file to include "NULL" a= nd > case insensitive > Importance: High >=20 > As per ECR 1349 change in UEFI Shell Specification 2.2, expanding > a special output file name to include "NULL". Previously it only > supported "NUL" as a special output file and it was case sensitive. > With this change both "NUL" and "NULL" are special output file and > checked as case insensitive. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Tapan Shah > --- > ShellPkg/Application/Shell/ShellParametersProtocol.c | 3 ++- > ShellPkg/Application/Shell/ShellProtocol.c | 6 ++++-- > ShellPkg/Library/UefiShellLib/UefiShellLib.c | 5 ++++- > ShellPkg/Library/UefiShellLib/UefiShellLib.h | 2 ++ > 4 files changed, 12 insertions(+), 4 deletions(-) >=20 > diff --git a/ShellPkg/Application/Shell/ShellParametersProtocol.c > b/ShellPkg/Application/Shell/ShellParametersProtocol.c > index 3684f9c..58156a2 100644 > --- a/ShellPkg/Application/Shell/ShellParametersProtocol.c > +++ b/ShellPkg/Application/Shell/ShellParametersProtocol.c > @@ -2,6 +2,7 @@ > Member functions of EFI_SHELL_PARAMETERS_PROTOCOL and functions > for creation, > manipulation, and initialization of EFI_SHELL_PARAMETERS_PROTOCOL. >=20 > + (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> Copyright (C) 2014, Red Hat, Inc. > (C) Copyright 2013 Hewlett-Packard Development Company, L.P.
> Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.
> @@ -1174,7 +1175,7 @@ UpdateStdInStdOutStdErr( > if (TempHandle =3D=3D NULL) { > Status =3D EFI_INVALID_PARAMETER; > } else { > - if (StrStr(StdOutFileName, L"NUL")=3D=3DStdOutFileName) { > + if (gUnicodeCollation->MetaiMatch (gUnicodeCollation, > StdOutFileName, L"NUL")) { > //no-op > } else if (!OutAppend && OutUnicode && !EFI_ERROR(Status)) { > Status =3D WriteFileTag (TempHandle); > diff --git a/ShellPkg/Application/Shell/ShellProtocol.c > b/ShellPkg/Application/Shell/ShellProtocol.c > index 6f29250..fb7dd84 100644 > --- a/ShellPkg/Application/Shell/ShellProtocol.c > +++ b/ShellPkg/Application/Shell/ShellProtocol.c > @@ -3,6 +3,7 @@ > manipulation, and initialization of EFI_SHELL_PROTOCOL. >=20 > (C) Copyright 2014 Hewlett-Packard Development Company, L.P.
> + (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the = BSD > License > @@ -1287,9 +1288,10 @@ EfiShellOpenFileByName( > } >=20 > // > - // Is this for NUL file > + // Is this for NUL / NULL file > // > - if (StrCmp(FileName, L"NUL") =3D=3D 0) { > + if ((gUnicodeCollation->StriColl (gUnicodeCollation, (CHAR16*)FileName= , > L"NUL") =3D=3D 0) || > + (gUnicodeCollation->StriColl (gUnicodeCollation, (CHAR16*)FileName= , > L"NULL") =3D=3D 0)) { > *FileHandle =3D &FileInterfaceNulFile; > return (EFI_SUCCESS); > } > diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > index 3dcdba6..27523e2 100644 > --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > @@ -1,6 +1,7 @@ > /** @file > Provides interface to shell functionality for shell commands and > applications. >=20 > + (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> Copyright 2016 Dell Inc. > Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
> This program and the accompanying materials > @@ -720,7 +721,9 @@ ShellOpenFileByName( > Status =3D gEfiShellProtocol->OpenFileByName(FileName, > FileHandle, > OpenMode); > - if (StrCmp(FileName, L"NUL") !=3D 0 && !EFI_ERROR(Status) && > ((OpenMode & EFI_FILE_MODE_CREATE) !=3D 0)){ > + if ((gUnicodeCollation->StriColl (gUnicodeCollation, (CHAR16*)FileNa= me, > L"NUL") !=3D 0) && > + (gUnicodeCollation->StriColl (gUnicodeCollation, (CHAR16*)FileNa= me, > L"NULL") !=3D 0) && > + !EFI_ERROR(Status) && ((OpenMode & EFI_FILE_MODE_CREATE) !=3D > 0)){ > FileInfo =3D FileFunctionMap.GetFileInfo(*FileHandle); > ASSERT(FileInfo !=3D NULL); > FileInfo->Attribute =3D Attributes; > diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.h > b/ShellPkg/Library/UefiShellLib/UefiShellLib.h > index 3596f7b..6903227 100644 > --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.h > +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.h > @@ -1,6 +1,7 @@ > /** @file > Provides interface to shell functionality for shell commands and > applications. >=20 > + (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the = BSD > License > @@ -38,6 +39,7 @@ > #include > #include > #include > +#include >=20 > typedef struct { > EFI_SHELL_GET_FILE_INFO GetFileInfo; > -- > 1.9.5.msysgit.0