From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7F7FF1A1FB5 for ; Thu, 22 Sep 2016 14:21:40 -0700 (PDT) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP; 22 Sep 2016 14:21:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,379,1470726000"; d="scan'208";a="1034887555" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 22 Sep 2016 14:21:39 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 22 Sep 2016 14:21:39 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.80]) by fmsmsx117.amr.corp.intel.com ([169.254.3.93]) with mapi id 14.03.0248.002; Thu, 22 Sep 2016 14:21:39 -0700 From: "Carsey, Jaben" To: Tapan Shah , "edk2-devel@lists.01.org" CC: "Carsey, Jaben" Thread-Topic: [PATCH] ShellPkg: Remove current working dir path ".;" from 'path' variable Thread-Index: AQHSFE9kTMAH/wXUbUGYHUBXd3fZQaCGBeSg Date: Thu, 22 Sep 2016 21:21:38 +0000 Message-ID: References: <1474493415-2876-1-git-send-email-tapandshah@hpe.com> In-Reply-To: <1474493415-2876-1-git-send-email-tapandshah@hpe.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDQxMjFkMmMtZWMyZi00NWU5LWI5NjEtZDlmZjJlMGViMThiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InlUVFl5SmJvclVoVGQ1cVhnMWdPWFwvY3lRemdwTndTN2cwZHprTVlEcGFFPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg: Remove current working dir path ".; " from 'path' variable X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Sep 2016 21:21:40 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey And commited. > -----Original Message----- > From: Tapan Shah [mailto:tapandshah@hpe.com] > Sent: Wednesday, September 21, 2016 2:30 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Tapan Shah > > Subject: [PATCH] ShellPkg: Remove current working dir path ".;" from 'pat= h' > variable > Importance: High >=20 > As per ECR 1349, latest UEFI Shell 2.2 specification has removed current > working directory > path ".;" from a default 'path' environment variable as current working > directory always > search first in system. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Tapan Shah > --- > ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c > b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c > index a97361c..b65676b 100644 > --- a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c > +++ b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c > @@ -1227,10 +1227,8 @@ ShellCommandAddMapItemAndUpdatePath( > ASSERT((NewPath =3D=3D NULL && NewPathSize =3D=3D 0) || (NewPath != =3D NULL)); > if (OriginalPath !=3D NULL) { > StrnCatGrow(&NewPath, &NewPathSize, OriginalPath, 0); > - } else { > - StrnCatGrow(&NewPath, &NewPathSize, L".\\", 0); > + StrnCatGrow(&NewPath, &NewPathSize, L";", 0); > } > - StrnCatGrow(&NewPath, &NewPathSize, L";", 0); > StrnCatGrow(&NewPath, &NewPathSize, Name, 0); > StrnCatGrow(&NewPath, &NewPathSize, L"\\efi\\tools\\;", 0); > StrnCatGrow(&NewPath, &NewPathSize, Name, 0); > -- > 1.9.5.msysgit.0