* [PATCH] ShellPkg: Update help output for disconnect command
@ 2016-09-23 16:10 Tapan Shah
2016-09-23 17:40 ` Carsey, Jaben
0 siblings, 1 reply; 2+ messages in thread
From: Tapan Shah @ 2016-09-23 16:10 UTC (permalink / raw)
To: edk2-devel; +Cc: jaben.carsey, Tapan Shah
Minor changes to match help output notes for disconnect command
with UEFI Shell 2.2 specification document.
Few other formatting changes to fit the help output in 80x25 screen size.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Tapan Shah <tapandshah@hpe.com>
---
.../UefiShellDriver1CommandsLib.uni | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.uni b/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.uni
index c6b8fcd..ac520e2 100644
--- a/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.uni
+++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.uni
@@ -308,11 +308,11 @@
" -r - Disconnects all drivers from all devices, then reconnect\r\n"
" consoles.\r\n"
" -nc - Do not reconnect the console devices.\r\n"
-" DeviceHandle - Specifies a device handle (a hexadecimal number). If not specified, then\r\n"
-" disconnect DriverHandle.\r\n"
+" DeviceHandle - Specifies a device handle (a hexadecimal number). If not\r\n"
+" specified, then disconnect DriverHandle.\r\n"
" DriverHandle - Specifies a driver handle (a hexadecimal number).\r\n"
-" ChildHandle - Specifies a child handle of a device (a hexadecimal number). If not\r\n"
-" specified, then all child handles of DeviceHandle are \r\n"
+" ChildHandle - Specifies a child handle of a device (a hexadecimal number).\r\n"
+" If not specified, then all child handles of DeviceHandle are\r\n"
" disconnected.\r\n"
".SH DESCRIPTION\r\n"
" \r\n"
@@ -322,8 +322,9 @@
" 2. If the 'ChildHandle' parameter is not specified, the default is to\r\n"
" disconnect all child handles of the 'DeviceHandle'.\r\n"
" 3. If the '-r' option is specified, all consoles and drivers will be\r\n"
-" disconnected from all devices in the system. In this case, no other\r\n"
-" parameters are allowed.\r\n"
+" disconnected from all devices in the system, then consoles are\r\n"
+" reconnected. If the '-nc' option is also spcified, then console devices\r\n"
+" are not reconnected.\r\n"
" 4. This command does not support output redirection.\r\n"
".SH EXAMPLES\r\n"
" \r\n"
--
1.9.5.msysgit.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ShellPkg: Update help output for disconnect command
2016-09-23 16:10 [PATCH] ShellPkg: Update help output for disconnect command Tapan Shah
@ 2016-09-23 17:40 ` Carsey, Jaben
0 siblings, 0 replies; 2+ messages in thread
From: Carsey, Jaben @ 2016-09-23 17:40 UTC (permalink / raw)
To: Tapan Shah, edk2-devel@lists.01.org; +Cc: Carsey, Jaben
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
And commited.
> -----Original Message-----
> From: Tapan Shah [mailto:tapandshah@hpe.com]
> Sent: Friday, September 23, 2016 9:10 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Tapan Shah
> <tapandshah@hpe.com>
> Subject: [PATCH] ShellPkg: Update help output for disconnect command
> Importance: High
>
> Minor changes to match help output notes for disconnect command
> with UEFI Shell 2.2 specification document.
>
> Few other formatting changes to fit the help output in 80x25 screen size.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Tapan Shah <tapandshah@hpe.com>
> ---
> .../UefiShellDriver1CommandsLib.uni | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Command
> sLib.uni
> b/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Comman
> dsLib.uni
> index c6b8fcd..ac520e2 100644
> ---
> a/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Command
> sLib.uni
> +++
> b/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Comman
> dsLib.uni
> @@ -308,11 +308,11 @@
> " -r - Disconnects all drivers from all devices, then reconnect\r\n"
> " consoles.\r\n"
> " -nc - Do not reconnect the console devices.\r\n"
> -" DeviceHandle - Specifies a device handle (a hexadecimal number). If not
> specified, then\r\n"
> -" disconnect DriverHandle.\r\n"
> +" DeviceHandle - Specifies a device handle (a hexadecimal number). If
> not\r\n"
> +" specified, then disconnect DriverHandle.\r\n"
> " DriverHandle - Specifies a driver handle (a hexadecimal number).\r\n"
> -" ChildHandle - Specifies a child handle of a device (a hexadecimal number).
> If not\r\n"
> -" specified, then all child handles of DeviceHandle are \r\n"
> +" ChildHandle - Specifies a child handle of a device (a hexadecimal
> number).\r\n"
> +" If not specified, then all child handles of DeviceHandle are\r\n"
> " disconnected.\r\n"
> ".SH DESCRIPTION\r\n"
> " \r\n"
> @@ -322,8 +322,9 @@
> " 2. If the 'ChildHandle' parameter is not specified, the default is to\r\n"
> " disconnect all child handles of the 'DeviceHandle'.\r\n"
> " 3. If the '-r' option is specified, all consoles and drivers will be\r\n"
> -" disconnected from all devices in the system. In this case, no other\r\n"
> -" parameters are allowed.\r\n"
> +" disconnected from all devices in the system, then consoles are\r\n"
> +" reconnected. If the '-nc' option is also spcified, then console
> devices\r\n"
> +" are not reconnected.\r\n"
> " 4. This command does not support output redirection.\r\n"
> ".SH EXAMPLES\r\n"
> " \r\n"
> --
> 1.9.5.msysgit.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-23 17:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-23 16:10 [PATCH] ShellPkg: Update help output for disconnect command Tapan Shah
2016-09-23 17:40 ` Carsey, Jaben
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox