From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 696971A1E0F for ; Fri, 30 Sep 2016 08:13:11 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP; 30 Sep 2016 08:13:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,273,1473145200"; d="scan'208";a="174987140" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 30 Sep 2016 08:13:12 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 30 Sep 2016 08:13:10 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.167]) by FMSMSX109.amr.corp.intel.com ([169.254.15.235]) with mapi id 14.03.0248.002; Fri, 30 Sep 2016 08:13:09 -0700 From: "Carsey, Jaben" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" CC: "Carsey, Jaben" Thread-Topic: [edk2] [PATCH 00/11] Remove unnecessary EFIAPI Thread-Index: AQHSGvNzZ+0LCYaUyU+ll4TnUhG6S6CSJE7A Date: Fri, 30 Sep 2016 15:13:08 +0000 Message-ID: References: <20160930081752.569916-1-ruiyu.ni@intel.com> In-Reply-To: <20160930081752.569916-1-ruiyu.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjM3YWQwMTctYTZlZC00MjY4LWEzNjctYzgyNmQ3OGU0YjRhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkJIaUZVdzYzVkFZMjlsV1dYaysxc3ZsZ0h2STJrVmdXbWljNGdCSTV1OWc9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [PATCH 00/11] Remove unnecessary EFIAPI X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Sep 2016 15:13:11 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I have no objection. Can you explain the benefit or just remove confusion? Reviewed-by: Jaben Carsey > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Friday, September 30, 2016 1:18 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 00/11] Remove unnecessary EFIAPI > Importance: High >=20 > Many Shell internal functions have EFIAPI modifier. > But it's not necessary. The patch serials remove the unnecessary > EFIAPI. >=20 > Ruiyu Ni (11): > ShellPkg/Shell: Remove unnecessary EFIAPI > ShellPkg/UefiShellDebug1CommandsLib: Remove unnecessary EFIAPI > ShellPkg/UefiShellDriver1CommandsLib: Remove unnecessary EFIAPI > ShellPkg/UefiShellLevel1CommandsLib: Remove unnecessary EFIAPI > ShellPkg/UefiShellLevel2CommandsLib: Remove unnecessary EFIAPI > ShellPkg/UefiShellLevel3CommandsLib: Remove unnecessary EFIAPI > ShellPkg/UefiShellParsingLib: Remove unnecessary EFIAPI > ShellPkg/UefiShellBcfgCommandLib: Remove unnecessary EFIAPI > ShellPkg/UefiShellCommandLib: Remove unnecessary EFIAPI > ShellPkg/UefiShellLib: Remove unnecessary EFIAPI > ShellPkg/UefiShellNetwork1CommandsLib: Remove unnecessary EFIAPI >=20 > ShellPkg/Application/Shell/ConsoleLogger.c | 10 ----- > ShellPkg/Application/Shell/ConsoleLogger.h | 6 --- > ShellPkg/Application/Shell/ConsoleWrappers.c | 4 -- > ShellPkg/Application/Shell/ConsoleWrappers.h | 4 -- > ShellPkg/Application/Shell/FileHandleInternal.h | 3 -- > ShellPkg/Application/Shell/FileHandleWrappers.c | 6 --- > ShellPkg/Application/Shell/FileHandleWrappers.h | 2 - > ShellPkg/Application/Shell/Shell.c | 36 ----------------= - > ShellPkg/Application/Shell/Shell.h | 16 -------- > ShellPkg/Application/Shell/ShellEnvVar.c | 4 -- > ShellPkg/Application/Shell/ShellEnvVar.h | 4 -- > ShellPkg/Application/Shell/ShellManParser.c | 9 ----- > ShellPkg/Application/Shell/ShellManParser.h | 2 - > .../Application/Shell/ShellParametersProtocol.c | 14 ------- > .../Application/Shell/ShellParametersProtocol.h | 8 ---- > ShellPkg/Application/Shell/ShellProtocol.c | 25 ++---------- > ShellPkg/Application/Shell/ShellProtocol.h | 9 ----- > .../UefiHandleParsingLib/UefiHandleParsingLib.c | 6 --- > .../UefiShellBcfgCommandLib.c | 9 ----- > .../Library/UefiShellCommandLib/ConsistMapping.c | 3 -- > .../UefiShellCommandLib/UefiShellCommandLib.c | 6 --- > .../Library/UefiShellDebug1CommandsLib/Compress.c | 30 --------------- > ShellPkg/Library/UefiShellDebug1CommandsLib/Dblk.c | 1 - > ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c | 2 - > .../Library/UefiShellDebug1CommandsLib/DmpStore.c | 3 -- > .../UefiShellDebug1CommandsLib/Edit/FileBuffer.c | 45 ----------------= ------ > .../UefiShellDebug1CommandsLib/Edit/FileBuffer.h | 17 -------- > .../Edit/MainTextEditor.c | 9 ----- > .../Edit/MainTextEditor.h | 5 --- > .../Library/UefiShellDebug1CommandsLib/Edit/Misc.c | 2 - > .../Library/UefiShellDebug1CommandsLib/Edit/Misc.h | 2 - > .../UefiShellDebug1CommandsLib/EditInputBar.c | 7 ---- > .../UefiShellDebug1CommandsLib/EditInputBar.h | 6 --- > .../UefiShellDebug1CommandsLib/EditMenuBar.c | 6 --- > .../UefiShellDebug1CommandsLib/EditMenuBar.h | 6 --- > .../UefiShellDebug1CommandsLib/EditStatusBar.c | 7 ---- > .../UefiShellDebug1CommandsLib/EditStatusBar.h | 7 ---- > .../UefiShellDebug1CommandsLib/EditTitleBar.c | 3 -- > .../UefiShellDebug1CommandsLib/EditTitleBar.h | 3 -- > .../HexEdit/BufferImage.c | 9 ----- > .../HexEdit/BufferImage.h | 4 -- > .../UefiShellDebug1CommandsLib/HexEdit/DiskImage.c | 1 - > .../HexEdit/MainHexEditor.c | 1 - > .../HexEdit/MainHexEditor.h | 1 - > .../UefiShellDebug1CommandsLib/LoadPciRom.c | 2 - > ShellPkg/Library/UefiShellDebug1CommandsLib/Mm.c | 1 - > ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c | 18 --------- > .../Library/UefiShellDebug1CommandsLib/SerMode.c | 1 - > .../Library/UefiShellDebug1CommandsLib/SetVar.c | 1 - > .../SmbiosView/EventLogInfo.c | 5 --- > .../SmbiosView/EventLogInfo.h | 5 --- > .../SmbiosView/SmbiosView.c | 8 ---- > .../SmbiosView/SmbiosView.h | 7 ---- > .../UefiShellDebug1CommandsLib.c | 9 ----- > .../UefiShellDebug1CommandsLib.h | 7 ---- > .../Library/UefiShellDriver1CommandsLib/Connect.c | 3 -- > .../Library/UefiShellDriver1CommandsLib/DevTree.c | 1 - > .../Library/UefiShellDriver1CommandsLib/Devices.c | 1 - > ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c | 9 ----- > .../UefiShellDriver1CommandsLib/Disconnect.c | 1 - > .../Library/UefiShellDriver1CommandsLib/Drivers.c | 4 -- > .../Library/UefiShellDriver1CommandsLib/DrvCfg.c | 7 ---- > .../Library/UefiShellDriver1CommandsLib/DrvDiag.c | 1 - > .../Library/UefiShellDriver1CommandsLib/OpenInfo.c | 1 - > .../UefiShellDriver1CommandsLib.h | 1 - > .../Library/UefiShellDriver1CommandsLib/Unload.c | 1 - > ShellPkg/Library/UefiShellLevel1CommandsLib/For.c | 5 --- > ShellPkg/Library/UefiShellLevel1CommandsLib/If.c | 6 --- > .../UefiShellLevel1CommandsLib.c | 2 - > .../UefiShellLevel1CommandsLib.h | 1 - > ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c | 4 -- > ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c | 2 - > ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c | 5 --- > ShellPkg/Library/UefiShellLevel2CommandsLib/Map.c | 12 ------ > ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c | 7 ---- > .../Library/UefiShellLevel2CommandsLib/Parse.c | 3 -- > ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c | 3 -- > ShellPkg/Library/UefiShellLevel2CommandsLib/Set.c | 1 - > .../Library/UefiShellLevel2CommandsLib/TimeDate.c | 4 -- > .../UefiShellLevel2CommandsLib.c | 5 --- > .../UefiShellLevel2CommandsLib.h | 6 --- > ShellPkg/Library/UefiShellLevel2CommandsLib/Vol.c | 1 - > .../Library/UefiShellLevel3CommandsLib/Alias.c | 1 - > ShellPkg/Library/UefiShellLevel3CommandsLib/Help.c | 4 -- > .../Library/UefiShellLevel3CommandsLib/Touch.c | 2 - > ShellPkg/Library/UefiShellLevel3CommandsLib/Type.c | 1 - > ShellPkg/Library/UefiShellLib/UefiShellLib.c | 14 ------- > ShellPkg/Library/UefiShellLib/UefiShellLib.h | 2 - > .../Library/UefiShellNetwork1CommandsLib/Ping.c | 14 ------- > 89 files changed, 4 insertions(+), 558 deletions(-) >=20 > -- > 2.9.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel