From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9267C1A1E0E for ; Wed, 5 Oct 2016 08:40:45 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP; 05 Oct 2016 08:40:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,449,1473145200"; d="scan'208";a="176675647" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 05 Oct 2016 08:40:45 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.167]) by fmsmsx104.amr.corp.intel.com ([169.254.3.169]) with mapi id 14.03.0248.002; Wed, 5 Oct 2016 08:40:44 -0700 From: "Carsey, Jaben" To: Supreeth Venkatesh , edk2-devel-01 , "Shah, Tapan (tapandshah@hpe.com)" CC: Leif Lindholm , "Carsey, Jaben" Thread-Topic: Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform Thread-Index: AdIekL1EjMpAqwOYRWKk8YKyvfLMLgAjbAlw Date: Wed, 5 Oct 2016 15:40:44 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjFiNmZkYjQtYjcwOC00NWU0LTgxYjQtY2IzNTMyZmQzZjE4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkFFTWQ5dUNRUnQ2VllWNWFSa1VWck9SVERHSWUwVVZ3TEZGS1kxMFlmNEk9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2016 15:40:45 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Tapan, Could this be a side effect of your patch? Should we allow the UefiShellLi= b to continue without this protocol and then return an error only when the = OpenFile is called? Also, it looks like we never properly initialize mUnicodeCollationProtocol.= We check for NULL in Constructor, but nothing else... -Jaben > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Supreeth Venkatesh > Sent: Tuesday, October 04, 2016 3:51 PM > To: edk2-devel-01 > Cc: Leif Lindholm > Subject: [edk2] Assert in ShellPkg with latest tianocore edk2 source on t= he > Reference Platform > Importance: High >=20 > All, >=20 > Recently, I updated to latest edk2 master (yesterday's) and I am actually > encountering assert in ShellPkg/Library/UefiShellLib/UefiShellLib.c >=20 > if (mUnicodeCollationProtocol =3D=3D NULL) { > Status =3D gBS->LocateProtocol (&gEfiUnicodeCollation2ProtocolGuid, N= ULL, > (VOID**)&mUnicodeCollationProtocol); > ASSERT_EFI_ERROR (Status); > } >=20 > It was working few weeks back and has now stopped working. > It's probably because the platform is unable to locate this protocol > "UnicodeCollationProtocol". > Is Anyone else facing the same issue? > Does the new ShellPkg requires additional packages/infs to be included in > the platform description file to work with latest changes to get past th= is > error? >=20 > Thanks, > Supreeth > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended reci= pient, > please notify the sender immediately and do not disclose the contents to = any > other person, use it for any purpose, or store or copy the information in= any > medium. Thank you. > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel