From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 31A9E1A1E30 for ; Mon, 17 Oct 2016 09:30:30 -0700 (PDT) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 17 Oct 2016 09:30:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,357,1473145200"; d="scan'208";a="890844990" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga003.jf.intel.com with ESMTP; 17 Oct 2016 09:30:30 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 17 Oct 2016 09:30:28 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.167]) by fmsmsx158.amr.corp.intel.com ([169.254.15.158]) with mapi id 14.03.0248.002; Mon, 17 Oct 2016 09:30:28 -0700 From: "Carsey, Jaben" To: "Yao, Jiewen" , Tim Lewis , "Ni, Ruiyu" , "edk2-devel@lists.01.org" CC: "Carsey, Jaben" Thread-Topic: [edk2] [PATCH 0/5] Move Shell protocol definitions to MdePkg Thread-Index: AQHSJf+eCCIdCjgYMUuTEwsfPwM/OqCoYZCAgAABYYCAADRcgIABYmsAgALhjlA= Date: Mon, 17 Oct 2016 16:30:27 +0000 Message-ID: References: <20161014094431.473584-1-ruiyu.ni@intel.com> <74D8A39837DF1E4DA445A8C0B3885C50386B192B@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C50386B1971@shsmsx102.ccr.corp.intel.com> <7236196A5DF6C040855A6D96F556A53F3F6BEF@msmail.insydesw.com.tw> <74D8A39837DF1E4DA445A8C0B3885C50386B1CEE@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C50386B1CEE@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTY4MDQ1MmYtNGNlYy00M2UyLWFhNmEtNThmZTEyMzg1MDliIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImRVS2xtN3RXNzBGZ0plakJwbzJTNzJpb1RFYVAxMlwvczFoczJVVlQzOURRPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [PATCH 0/5] Move Shell protocol definitions to MdePkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2016 16:30:30 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yao, How many closed source packages are going to be working against the trunk? = Don't most of those platforms already have a copy of ShellPkg and therefor= e they wont care? -Jaben > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Yao, Jiewen > Sent: Saturday, October 15, 2016 6:30 AM > To: Tim Lewis ; Ni, Ruiyu ; > edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH 0/5] Move Shell protocol definitions to MdePkg > Importance: High >=20 > Of course, it is fine to give a good name in MdePkg. :) >=20 > My concern is only about "Compatibility". > This series patch only updated ArmPkg and EmbeddedPkg. > But there might be more close source IP protected packages using the > original header file. >=20 > That is why I propose a compatible way: We give a good file name in MdePk= g. > At same time, we can keep the old file name in ShellPkg to include the go= od > name in MdePkg. >=20 > I recommend we give a solution to make close source package unchanged > after this patch is applied. >=20 > Thank you > Yao Jiewen >=20 >=20 > From: Tim Lewis [mailto:tim.lewis@insyde.com] > Sent: Saturday, October 15, 2016 12:21 AM > To: Yao, Jiewen ; Ni, Ruiyu ; > edk2-devel@lists.01.org > Subject: RE: [edk2] [PATCH 0/5] Move Shell protocol definitions to MdePkg >=20 > I prefer the renamed .h file, even though I have substantial investment i= n > the current infrastructure. >=20 > Why? Because engineers don't have time to remember "how does protocol > X translate to header file Y" It should be a consistent rule. How many ti= mes > have I needed to grep the header file name just because I got a build err= or > because the rule wasn't predictable. >=20 > 1) remove the EFI_ prefix and the _PROTOCOL suffix > (EFI_BLOCK_IO_PROTOCOL -> BLOCK_IO > 2) Convert to upper-and-lower case, BLOCK_IO -> Block_Io > 3) Remove the _ (Block_Io -> BlockIo) > 4) add a .h BlockIo -> BlockIo.h >=20 > Most protocol and PPI header files already follow this rule. The current > header files for shell are among the few exceptions, because they don't > follow this. >=20 > Tim >=20 > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Yao, Jiewen > Sent: Friday, October 14, 2016 6:14 AM > To: Yao, Jiewen >; > Ni, Ruiyu >; edk2- > devel@lists.01.org > Subject: Re: [edk2] [PATCH 0/5] Move Shell protocol definitions to MdePkg >=20 > Or if you really think we should give a better name. >=20 > My recommendation is: >=20 > 1) We add content in MdePkg. >=20 > 2) We can keep the old protocol file in ShellPkg, but let .h in shel= lPkg > include the .h in MdePkg. >=20 > Then we can avoid duplicated code and make it a compatible solution to > avoid other module update. >=20 > Thank you > Yao Jiewen >=20 > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Yao, Jiewen > Sent: Friday, October 14, 2016 9:09 PM > To: Ni, Ruiyu >; edk2- > devel@lists.01.org > Subject: Re: [edk2] [PATCH 0/5] Move Shell protocol definitions to MdePkg >=20 > Hi > I think the requests is just to *move*. >=20 > There is no request to *rename*. >=20 > Can we just move to avoid other update? >=20 >=20 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Ruiyu Ni > > Sent: Friday, October 14, 2016 5:44 PM > > To: edk2-devel@lists.01.org devel@lists.01.org%3cmailto:edk2-devel@lists.01.org>> > > Subject: [edk2] [PATCH 0/5] Move Shell protocol definitions to MdePkg > > > > The patches moves Shell spec defined protocol definitions to MdePkg > > and updates all references. > > Content of ShellBase.h is moved to Protocol/Shell.h and ShellBase.h is > > removed. > > > > Ruiyu Ni (5): > > ShellPkg: Move SHELL_FREE_NON_NULL from ShellBase.h to ShellLib.h > > MdePkg: Include Shell/ShellDynamicCommand/ShellParameters > > definitions > > ArmPkg/LinuxLoader: Reference Shell protocols in MdePkg > > EmbeddedPkg/FdtPlatformDxe: Reference Shell protocols in MdePkg > > ShellPkg: Remove Shell/ShellDynamicCommand/ShellParameter > > definitions > > > > ArmPkg/Application/LinuxLoader/LinuxLoader.h | 4 +- > > EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.h | 4 +- > > .../EfiShell.h =3D> MdePkg/Include/Protocol/Shell.h | 134 > > +++++++++++++++++- > > .../Include/Protocol/ShellDynamicCommand.h | 7 +- > > .../Include/Protocol/ShellParameters.h | 4 +- > > MdePkg/MdePkg.dec | 15 ++ > > ShellPkg/Application/Shell/Shell.h | 5 +- > > ShellPkg/Include/Library/ShellCommandLib.h | 5 +- > > ShellPkg/Include/Library/ShellLib.h | 14 +- > > ShellPkg/Include/ShellBase.h | 157 > > --------------------- > > ShellPkg/Library/UefiDpLib/Dp.h | 3 +- > > ShellPkg/Library/UefiDpLib/UefiDpLib.h | 7 +- > > .../UefiHandleParsingLib/UefiHandleParsingLib.h | 8 +- > > .../UefiShellBcfgCommandLib.c | 5 +- > > .../UefiShellCEntryLib/UefiShellCEntryLib.c | 6 +- > > .../UefiShellCommandLib/UefiShellCommandLib.h | 7 +- > > .../Library/UefiShellDebug1CommandsLib/Compress.c | 7 +- > > .../UefiShellDebug1CommandsLib.h | 7 +- > > .../UefiShellDriver1CommandsLib.h | 7 +- > > .../UefiShellLevel1CommandsLib.h | 7 +- > > .../UefiShellLevel2CommandsLib.h | 7 +- > > ShellPkg/Library/UefiShellLevel3CommandsLib/Help.c | 2 +- > > .../UefiShellLevel3CommandsLib.h | 7 +- > > ShellPkg/Library/UefiShellLib/UefiShellLib.c | 1 - > > ShellPkg/Library/UefiShellLib/UefiShellLib.h | 6 +- > > .../UefiShellNetwork1CommandsLib.h | 3 +- > > .../UefiShellTftpCommandLib.h | 3 +- > > ShellPkg/ShellPkg.dec | 3 - > > ShellPkg/ShellPkg.dsc | 2 + > > 29 files changed, 213 insertions(+), 234 deletions(-) rename > > ShellPkg/Include/Protocol/EfiShell.h =3D> > > MdePkg/Include/Protocol/Shell.h (92%) rename > > ShellPkg/Include/Protocol/EfiShellDynamicCommand.h =3D> > > MdePkg/Include/Protocol/ShellDynamicCommand.h (92%) rename > > ShellPkg/Include/Protocol/EfiShellParameters.h =3D> > > MdePkg/Include/Protocol/ShellParameters.h (92%) delete mode 100644 > > ShellPkg/Include/ShellBase.h > > > > -- > > 2.9.0.windows.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org devel@lists.01.org%3cmailto:edk2-devel@lists.01.org>> > > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org devel@lists.01.org%3cmailto:edk2-devel@lists.01.org>> > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel