Re: [PATCH] GPT Shell Application/Library

["Carsey, Jaben" <jaben.carsey@intel.com>]

Laszlo,

We don't have a hard and fast rule about command names.  The simple thing is that we may have a conflict in the future, but I don't see that as likely at this point.  

Your comment about _ was when a custom implementation wants to extend an existing defined command with a non-standard parameter. For example there is an _exit parameter to the shell that tells the shell to auto-close after running the initial command line passed into it.

-Jaben

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Monday, October 17, 2016 2:44 AM
> To: Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu
> <ruiyu.ni@intel.com>; edk2-devel@lists.01.org <edk2-devel@ml01.01.org>
> Subject: Re: [edk2] [PATCH] GPT Shell Application/Library
> Importance: High
> 
> On 10/17/16 08:49, Vladimir Olovyannikov wrote:
> > Thank you Laszlo,
> >
> > Sorry, I missed the fields; it is my first contribution, I will add the
> > required lines, review the source according to your comments and will
> > resubmit the patch.
> > So do you think the command should be _gpt instead of gpt? I was
> > following TFTP and SF commands as a template.
> 
> Right, at this point I'm confused about TFTP even, in retrospect. It's
> not in the spec, so I guess it should have been _TFTP. I hope Jaben and
> Ray can advise us. :)
> 
> Thanks
> Laszlo
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel