From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DCC0A1A1E30 for ; Mon, 17 Oct 2016 09:35:45 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP; 17 Oct 2016 09:35:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,357,1473145200"; d="scan'208";a="180675386" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 17 Oct 2016 09:35:44 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 17 Oct 2016 09:35:44 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.167]) by fmsmsx120.amr.corp.intel.com ([169.254.15.251]) with mapi id 14.03.0248.002; Mon, 17 Oct 2016 09:35:44 -0700 From: "Carsey, Jaben" To: Laszlo Ersek , Vladimir Olovyannikov CC: "Ni, Ruiyu" , "edk2-devel@lists.01.org" , "Carsey, Jaben" Thread-Topic: [edk2] [PATCH] GPT Shell Application/Library Thread-Index: AQHSJ22pkbT3FyyYSEa8i7cbwLd+taCr98IAgAA+ujuAAKXjAP///S8Q Date: Mon, 17 Oct 2016 16:35:43 +0000 Message-ID: References: <1476595420-12566-1-git-send-email-vladimir.olovyannikov@broadcom.com> <40b80588-1bb4-e5f2-439c-97a405c873d3@redhat.com> <54ded7fa-1f35-1bf9-b5e6-d78f2984bf86@redhat.com> In-Reply-To: <54ded7fa-1f35-1bf9-b5e6-d78f2984bf86@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTVmYzA3ZGQtNjU3Yy00MTAwLTg3NTYtYWEzZjIxODY1ZGEyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjRvZVpXRGJXK2d2akYxaVpYc0ltZjErakN4dnA2Z214V3FcL1hKOUpSYlJFPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [PATCH] GPT Shell Application/Library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2016 16:35:46 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Laszlo, We don't have a hard and fast rule about command names. The simple thing i= s that we may have a conflict in the future, but I don't see that as likely= at this point. =20 Your comment about _ was when a custom implementation wants to extend an ex= isting defined command with a non-standard parameter. For example there is = an _exit parameter to the shell that tells the shell to auto-close after ru= nning the initial command line passed into it. -Jaben > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Monday, October 17, 2016 2:44 AM > To: Vladimir Olovyannikov > Cc: Carsey, Jaben ; Ni, Ruiyu > ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] GPT Shell Application/Library > Importance: High >=20 > On 10/17/16 08:49, Vladimir Olovyannikov wrote: > > Thank you Laszlo, > > > > Sorry, I missed the fields; it is my first contribution, I will add the > > required lines, review the source according to your comments and will > > resubmit the patch. > > So do you think the command should be _gpt instead of gpt? I was > > following TFTP and SF commands as a template. >=20 > Right, at this point I'm confused about TFTP even, in retrospect. It's > not in the spec, so I guess it should have been _TFTP. I hope Jaben and > Ray can advise us. :) >=20 > Thanks > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel