From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Carsey, Jaben" <jaben.carsey@intel.com>
Subject: Re: [PATCH v2 0/8] Move Shell protocols definition to MdePkg
Date: Tue, 18 Oct 2016 14:53:31 +0000 [thread overview]
Message-ID: <CB6E33457884FA40993F35157061515C54A925CD@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <20161018084613.58420-1-ruiyu.ni@intel.com>
I am good with this.
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Tuesday, October 18, 2016 1:46 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH v2 0/8] Move Shell protocols definition to MdePkg
> Importance: High
>
> The patches moves Shell spec defined protocol definitions to
> MdePkg and updates all references.
> Content of ShellBase.h is moved to Protocol/Shell.h and
> ShellBase.h is removed.
>
> In V2, to keep maximum backward compatibility, the header files
> in ShellPkg will not be removed until all consumers are
> updated to reference the protocol definitions in MdePkg.
> "git mv" command is used to keep the history of the
> protocol definition header files when moving them to MdePkg.
>
>
> Ruiyu Ni (8):
> ShellPkg: Move SHELL_FREE_NON_NULL from ShellBase.h to ShellLib.h
> MdePkg: Include Shell/ShellDynamicCommand/ShellParameters definitions
> ShellPkg: Update header files to reference MdePkg protocol definition
> MdePkg: Merge ShellBase.h and remove Efi prefix from header files
> ArmPkg/LinuxLoader: Reference Shell protocols in MdePkg
> EmbeddedPkg/FdtPlatformDxe: Reference Shell protocols in MdePkg
> ShellPkg: Update sources to include MdePkg protocol definitions
> ArmPlatformPkg/ArmShellCmdRunAxf: Reference MdePkg protocol
> definition
>
> ArmPkg/Application/LinuxLoader/LinuxLoader.h | 4 +-
> .../Library/ArmShellCmdRunAxf/ArmShellCmdRunAxf.h | 6 +-
> EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.h | 4 +-
> .../EfiShell.h => MdePkg/Include/Protocol/Shell.h | 138 ++-
> .../Include/Protocol/ShellDynamicCommand.h | 11 +-
> .../Include/Protocol/ShellParameters.h | 8 +-
> MdePkg/MdePkg.dec | 15 +
> ShellPkg/Application/Shell/Shell.h | 5 +-
> ShellPkg/Include/Library/ShellCommandLib.h | 5 +-
> ShellPkg/Include/Library/ShellLib.h | 14 +-
> ShellPkg/Include/Protocol/EfiShell.h | 1125 +-------------------
> ShellPkg/Include/Protocol/EfiShellDynamicCommand.h | 73 +-
> ShellPkg/Include/Protocol/EfiShellParameters.h | 48 +-
> ShellPkg/Include/ShellBase.h | 141 +--
> ShellPkg/Library/UefiDpLib/Dp.h | 3 +-
> ShellPkg/Library/UefiDpLib/UefiDpLib.h | 7 +-
> .../UefiHandleParsingLib/UefiHandleParsingLib.h | 8 +-
> .../UefiShellBcfgCommandLib.c | 5 +-
> .../UefiShellCEntryLib/UefiShellCEntryLib.c | 6 +-
> .../UefiShellCommandLib/UefiShellCommandLib.h | 7 +-
> .../Library/UefiShellDebug1CommandsLib/Compress.c | 7 +-
> .../UefiShellDebug1CommandsLib.h | 7 +-
> .../UefiShellDriver1CommandsLib.h | 7 +-
> .../UefiShellLevel1CommandsLib.h | 7 +-
> .../UefiShellLevel2CommandsLib.h | 7 +-
> ShellPkg/Library/UefiShellLevel3CommandsLib/Help.c | 2 +-
> .../UefiShellLevel3CommandsLib.h | 7 +-
> ShellPkg/Library/UefiShellLib/UefiShellLib.c | 1 -
> ShellPkg/Library/UefiShellLib/UefiShellLib.h | 6 +-
> .../UefiShellNetwork1CommandsLib.h | 3 +-
> .../UefiShellTftpCommandLib.h | 3 +-
> ShellPkg/ShellPkg.dec | 3 -
> ShellPkg/ShellPkg.dsc | 2 +
> 33 files changed, 235 insertions(+), 1460 deletions(-)
> copy ShellPkg/Include/Protocol/EfiShell.h =>
> MdePkg/Include/Protocol/Shell.h (91%)
> copy ShellPkg/Include/Protocol/EfiShellDynamicCommand.h =>
> MdePkg/Include/Protocol/ShellDynamicCommand.h (89%)
> copy ShellPkg/Include/Protocol/EfiShellParameters.h =>
> MdePkg/Include/Protocol/ShellParameters.h (87%)
>
> --
> 2.9.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2016-10-18 14:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 8:46 [PATCH v2 0/8] Move Shell protocols definition to MdePkg Ruiyu Ni
2016-10-18 8:46 ` [PATCH v2 1/8] ShellPkg: Move SHELL_FREE_NON_NULL from ShellBase.h to ShellLib.h Ruiyu Ni
2016-10-18 8:46 ` [PATCH v2 2/8] MdePkg: Include Shell/ShellDynamicCommand/ShellParameters definitions Ruiyu Ni
2016-10-18 8:46 ` [PATCH v2 3/8] ShellPkg: Update header files to reference MdePkg protocol definition Ruiyu Ni
2016-10-18 8:46 ` [PATCH v2 4/8] MdePkg: Merge ShellBase.h and remove Efi prefix from header files Ruiyu Ni
2016-10-18 8:46 ` [PATCH v2 5/8] ArmPkg/LinuxLoader: Reference Shell protocols in MdePkg Ruiyu Ni
2016-10-18 8:46 ` [PATCH v2 6/8] EmbeddedPkg/FdtPlatformDxe: " Ruiyu Ni
2016-10-18 8:46 ` [PATCH v2 7/8] ShellPkg: Update sources to include MdePkg protocol definitions Ruiyu Ni
2016-10-18 8:46 ` [PATCH v2 8/8] ArmPlatformPkg/ArmShellCmdRunAxf: Reference MdePkg protocol definition Ruiyu Ni
2016-10-18 10:00 ` Ard Biesheuvel
2016-10-18 14:53 ` Carsey, Jaben [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB6E33457884FA40993F35157061515C54A925CD@FMSMSX103.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox