From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 090C21A1E05 for ; Tue, 18 Oct 2016 08:13:30 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP; 18 Oct 2016 08:13:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,362,1473145200"; d="scan'208";a="1072141416" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 18 Oct 2016 08:13:26 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 18 Oct 2016 08:13:25 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.167]) by FMSMSX151.amr.corp.intel.com ([169.254.7.194]) with mapi id 14.03.0248.002; Tue, 18 Oct 2016 08:13:25 -0700 From: "Carsey, Jaben" To: Tim Lewis , "edk2-devel@lists.01.org" CC: "Carsey, Jaben" Thread-Topic: [shell] Problems in EfiShellGetGuidFromName Thread-Index: AdIlfdpU1v/3CG20S5OHaNM46qeDngDqw2agAAmhU1AAAK3DYA== Date: Tue, 18 Oct 2016 15:13:25 +0000 Message-ID: References: <7236196A5DF6C040855A6D96F556A53F3F660F@msmail.insydesw.com.tw> <7236196A5DF6C040855A6D96F556A53F3F84EF@msmail.insydesw.com.tw> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjY5OGY4MjUtYjdmNC00ODJiLTkzNzYtMjQ3NTQ1ZGEyNzUzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Iklrbm5MdnVmRFdqQ3RtZ3lQS0trTUc5VFZqa3JqYkM3cUxYVHJMbVBxRFk9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Subject: Re: [shell] Problems in EfiShellGetGuidFromName X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2016 15:13:30 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Never mind. Just saw patch. > -----Original Message----- > From: Carsey, Jaben > Sent: Tuesday, October 18, 2016 7:54 AM > To: 'Tim Lewis' ; edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: RE: [shell] Problems in EfiShellGetGuidFromName >=20 > I think you're right. I guess that there are not lots of users of this f= unction. >=20 > Can you submit a Bugzilla request? >=20 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Tim Lewis > > Sent: Tuesday, October 18, 2016 3:18 AM > > To: edk2-devel@lists.01.org > > Subject: [edk2] FW: [shell] Problems in EfiShellGetGuidFromName > > Importance: High > > > > Did anyone have a chance to look at this EFI_SHELL_PROTOCOL bug in the > > EDK2 implementation? > > > > Thanks, > > > > Tim > > > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Tim Lewis > > Sent: Thursday, October 13, 2016 11:16 AM > > To: edk2-devel-01 > > Subject: [edk2] [shell] Problems in EfiShellGetGuidFromName > > > > In EfiShellGetGuidFromName (ShellProtocol.c), we see: > > > > EfiShellGetGuidFromName( > > IN CONST CHAR16 *GuidName, > > OUT EFI_GUID *Guid > > ) > > { > > EFI_GUID *NewGuid; > > EFI_STATUS Status; > > > > if (Guid =3D=3D NULL || GuidName =3D=3D NULL) { > > return (EFI_INVALID_PARAMETER); > > } > > > > Status =3D GetGuidFromStringName(GuidName, NULL, &NewGuid); > > if (!EFI_ERROR(Status)) { > > CopyGuid(NewGuid, Guid); > > } > > return (Status); > > > > However, this doesn't work. Notice that CopyGuid places the output > > parameter as the 2nd parameter. But according to BaseMemoryLib: > > > > GUID * > > EFIAPI > > CopyGuid ( > > OUT GUID *DestinationGuid, > > IN CONST GUID *SourceGuid > > ); > > > > The destination should be the 1st parameter (not the second). > > > > > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel