Re: [PATCH 2/2] ShellPkg/Ifconfig: Enable setting MAC address

["Carsey, Jaben" <jaben.carsey@intel.com>]

Sounds good to me.

> -----Original Message-----
> From: Marcin Wojtas [mailto:mw@semihalf.com]
> Sent: Monday, November 07, 2016 3:55 AM
> To: Carsey, Jaben <jaben.carsey@intel.com>
> Cc: edk2-devel@lists.01.org; Tian, Feng <feng.tian@intel.com>;
> leif.lindholm@linaro.org; Gao, Liming <liming.gao@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2] [PATCH 2/2] ShellPkg/Ifconfig: Enable setting MAC
> address
> Importance: High
> 
> Hi Jaben,
> 
> 2016-11-04 21:38 GMT+01:00 Carsey, Jaben <jaben.carsey@intel.com>:
> > I think this is a good idea. But I see 2 issues.
> > 1 - ifconfig standard parameters are controlled by the UEFI Shell
> Specification.  If you want to extend the parameters you need to use
> parameters that start with underscore.  I do not quite know how to so this
> under the "-s" set of functions for this command.  Maybe just add this
> separate from "-s", using something like "-_mac"?
> 
> No, problem. Since this will be an additional parameter in
> mIfConfig[6]CheckList, and all consist of single letter, I propose
> "-_m". Is it ok?
> 
> > 2 - whatever change is done here should also be done to the ipv6 version
> of the command.
> >
> 
> Ok, I can see it should be not much than simple copy-paste.
> 
> Best regards,
> Marcin