public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: hegdenag <nagaraj-p.hegde@hpe.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
	"Wu, Jiaxin" <jiaxin.wu@intel.com>,
	"Carsey, Jaben" <jaben.carsey@intel.com>
Subject: Re: [PATCH v1 1/1] ShellPkg/Ping6: Add a note in help for TargetIp
Date: Mon, 7 Nov 2016 18:22:55 +0000	[thread overview]
Message-ID: <CB6E33457884FA40993F35157061515C54ABFBF4@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <20161107084048.19992-1-nagaraj-p.hegde@hpe.com>

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
And pushed.

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> hegdenag
> Sent: Monday, November 07, 2016 12:41 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu
> <ruiyu.ni@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [edk2] [PATCH v1 1/1] ShellPkg/Ping6: Add a note in help for
> TargetIp
> Importance: High
> 
> 'Ping6 TargetIp' is a valid command input but we bail out
> when TargetIp is a link local address because we would want
> the user to specify the NIC (via SourceIp) through which
> he/she would want to ping to TargetIp. This patch updates
> the help text to mention the same.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Hegde Nagaraj P <nagaraj-p.hegde@hpe.com>
> ---
> 
> ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Comm
> andsLib.uni | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git
> a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> mandsLib.uni
> b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> mandsLib.uni
> index 8f27e27..5adc5b5 100644
> ---
> a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> mandsLib.uni
> +++
> b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> mandsLib.uni
> @@ -99,6 +99,8 @@
>  "  -n count    Send request count, (default=10, min=1, max=10000).\r\n"
>  "  -s SourceIp Source IPv6 address.\r\n"
>  "  TargetIp    Target IPv6 address.\r\n"
> +"NOTES:\r\n"
> +"  1. When TargetIp is a link local address, SourceIp needs to be
> specified.\r\n"
>  ".SH EXAMPLES\r\n"
>  " \r\n"
>  "Examples:\r\n"
> --
> 2.8.3.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2016-11-07 18:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-07  8:40 [PATCH v1 1/1] ShellPkg/Ping6: Add a note in help for TargetIp hegdenag
2016-11-07 18:22 ` Carsey, Jaben [this message]
2016-11-08  0:25 ` Wu, Jiaxin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CB6E33457884FA40993F35157061515C54ABFBF4@FMSMSX103.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox