From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B9E4F81E45 for ; Thu, 10 Nov 2016 08:24:34 -0800 (PST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP; 10 Nov 2016 08:24:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,619,1473145200"; d="scan'208";a="29810828" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 10 Nov 2016 08:24:34 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 10 Nov 2016 08:24:34 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.203]) by FMSMSX113.amr.corp.intel.com ([169.254.13.160]) with mapi id 14.03.0248.002; Thu, 10 Nov 2016 08:24:34 -0800 From: "Carsey, Jaben" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" CC: "Carsey, Jaben" Thread-Topic: [PATCH] ShellPkg/ShellCommandLib: Add missing EFIAPI for public library APIs Thread-Index: AQHSOx/wk/kFNryFV0aS9A5KY3VyPaDSZ5Gg Date: Thu, 10 Nov 2016 16:24:33 +0000 Message-ID: References: <20161110065846.83148-1-ruiyu.ni@intel.com> In-Reply-To: <20161110065846.83148-1-ruiyu.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTQwMGJkNTgtZDg3ZS00MTEwLWFiYjgtZmEzMDBlNmQ1Njc5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlpZTlRoYUx2bXRzTk9DVU1vTDFvQWVRTWVDNmZ6TFd6cXVmWnlicUVcL3ZjPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg/ShellCommandLib: Add missing EFIAPI for public library APIs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Nov 2016 16:24:34 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: Ni, Ruiyu > Sent: Wednesday, November 09, 2016 10:59 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: [PATCH] ShellPkg/ShellCommandLib: Add missing EFIAPI for public > library APIs > Importance: High >=20 > DumpHex() and CatSDumpHex() are public library APIs but don't have > EFIAPI modifier. Add the missing EFIAPI. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni > Cc: Jaben Carsey > --- > ShellPkg/Include/Library/ShellCommandLib.h | 2 ++ > ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c | 4 +++- > 2 files changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/ShellPkg/Include/Library/ShellCommandLib.h > b/ShellPkg/Include/Library/ShellCommandLib.h > index 08de133..e9a2c03 100644 > --- a/ShellPkg/Include/Library/ShellCommandLib.h > +++ b/ShellPkg/Include/Library/ShellCommandLib.h > @@ -694,6 +694,7 @@ FreeBufferList ( > @param[in] UserData Pointer to some data. > **/ > VOID > +EFIAPI > DumpHex ( > IN UINTN Indent, > IN UINTN Offset, > @@ -711,6 +712,7 @@ DumpHex ( > @param[in] UserData The data to print out. > **/ > CHAR16* > +EFIAPI > CatSDumpHex ( > IN CHAR16 *Buffer, > IN UINTN Indent, > diff --git a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c > b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c > index 1391768..a2ebc8f 100644 > --- a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c > +++ b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c > @@ -1,7 +1,7 @@ > /** @file > Provides interface to shell internal functions for shell commands. >=20 > - Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved.
> + Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.
> (C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.
> (C) Copyright 2016 Hewlett Packard Enterprise Development LP
>=20 > @@ -1715,6 +1715,7 @@ FreeBufferList ( > @param[in] UserData The data to print out. > **/ > VOID > +EFIAPI > DumpHex ( > IN UINTN Indent, > IN UINTN Offset, > @@ -1767,6 +1768,7 @@ DumpHex ( > @param[in] UserData The data to print out. > **/ > CHAR16* > +EFIAPI > CatSDumpHex ( > IN CHAR16 *Buffer, > IN UINTN Indent, > -- > 2.9.0.windows.1