From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0601981E66 for ; Tue, 15 Nov 2016 07:59:28 -0800 (PST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP; 15 Nov 2016 07:59:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,495,1473145200"; d="scan'208";a="191686925" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 15 Nov 2016 07:59:32 -0800 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 15 Nov 2016 07:59:32 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.203]) by fmsmsx121.amr.corp.intel.com ([169.254.6.250]) with mapi id 14.03.0248.002; Tue, 15 Nov 2016 07:59:22 -0800 From: "Carsey, Jaben" To: "Bi, Dandan" , "Ni, Ruiyu" , "edk2-devel@lists.01.org" CC: "Carsey, Jaben" Thread-Topic: [PATCH] ShellPkg: #ifndef of header files should have postfix underscore Thread-Index: AQHSPuhj58wV16npEkmUFzFLnGm2RaDaNKAw Date: Tue, 15 Nov 2016 15:59:21 +0000 Message-ID: References: <20161115015726.168432-1-ruiyu.ni@intel.com> <3C0D5C461C9E904E8F62152F6274C0BB3965D6F0@shsmsx102.ccr.corp.intel.com> In-Reply-To: <3C0D5C461C9E904E8F62152F6274C0BB3965D6F0@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWY5MjM3YTMtYWU1OS00MTI1LTkzODgtNDIyZjdjMzk0Mzg0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IllGVlVnQVA0TzZaSTM0TzVIVng1RG52aTB4aTNiWGl4Z3MreDJMTWI3Qnc9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg: #ifndef of header files should have postfix underscore X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Nov 2016 15:59:28 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Bi= , > Dandan > Sent: Monday, November 14, 2016 6:31 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] ShellPkg: #ifndef of header files should have > postfix underscore > Importance: High >=20 > Reviewed-by: Dandan Bi >=20 > Thanks, > Dandan >=20 > -----Original Message----- > From: Ni, Ruiyu > Sent: Tuesday, November 15, 2016 9:57 AM > To: edk2-devel@lists.01.org > Cc: Bi, Dandan > Subject: [PATCH] ShellPkg: #ifndef of header files should have postfix > underscore >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni > Cc: Dandan Bi > --- > ShellPkg/Include/Protocol/EfiShell.h | 4 ++-- > ShellPkg/Include/Protocol/EfiShellDynamicCommand.h | 4 ++-- > ShellPkg/Include/Protocol/EfiShellParameters.h | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/ShellPkg/Include/Protocol/EfiShell.h > b/ShellPkg/Include/Protocol/EfiShell.h > index 4fb8f23..8e3c2fe 100644 > --- a/ShellPkg/Include/Protocol/EfiShell.h > +++ b/ShellPkg/Include/Protocol/EfiShell.h > @@ -13,8 +13,8 @@ >=20 > **/ >=20 > -#ifndef __EFI_SHELL_PROTOCOL_H__WRAPPER -#define > __EFI_SHELL_PROTOCOL_H__WRAPPER > +#ifndef __EFI_SHELL_PROTOCOL_H__WRAPPER__ #define > +__EFI_SHELL_PROTOCOL_H__WRAPPER__ >=20 > #include >=20 > diff --git a/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h > b/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h > index 43cb688..50f9398 100644 > --- a/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h > +++ b/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h > @@ -13,8 +13,8 @@ >=20 > **/ >=20 > -#ifndef __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER > -#define __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER > +#ifndef __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER__ > +#define __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER__ >=20 > #include >=20 > diff --git a/ShellPkg/Include/Protocol/EfiShellParameters.h > b/ShellPkg/Include/Protocol/EfiShellParameters.h > index ba8bd1a..184b029 100644 > --- a/ShellPkg/Include/Protocol/EfiShellParameters.h > +++ b/ShellPkg/Include/Protocol/EfiShellParameters.h > @@ -12,8 +12,8 @@ >=20 > **/ >=20 > -#ifndef __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER > -#define __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER > +#ifndef __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER__ > +#define __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER__ >=20 > #include >=20 > -- > 2.9.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel