public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Fu, Siyuan" <siyuan.fu@intel.com>, Gary Lin <glin@suse.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ye, Ting" <ting.ye@intel.com>,
	"Zhang, Lubo" <lubo.zhang@intel.com>,
	"Wu, Jiaxin" <jiaxin.wu@intel.com>,
	"Carsey, Jaben" <jaben.carsey@intel.com>
Subject: Re: [PATCH] ShellPkg: Assign the correct value to ShellStatus
Date: Wed, 7 Dec 2016 17:01:56 +0000	[thread overview]
Message-ID: <CB6E33457884FA40993F35157061515C54B0CE24@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <B1FF2E9001CE9041BD10B825821D5BC58A85CAC1@shsmsx102.ccr.corp.intel.com>

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fu,
> Siyuan
> Sent: Wednesday, December 07, 2016 1:20 AM
> To: Gary Lin <glin@suse.com>; edk2-devel@lists.01.org
> Cc: Ye, Ting <ting.ye@intel.com>; Zhang, Lubo <lubo.zhang@intel.com>; Wu,
> Jiaxin <jiaxin.wu@intel.com>
> Subject: Re: [edk2] [PATCH] ShellPkg: Assign the correct value to ShellStatus
> Importance: High
> 
> Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
> 
> 
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Gary Lin
> > Sent: Wednesday, December 7, 2016 11:41 AM
> > To: edk2-devel@lists.01.org
> > Cc: Ye, Ting <ting.ye@intel.com>; Zhang, Lubo <lubo.zhang@intel.com>;
> Fu,
> > Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> > Subject: [edk2] [PATCH] ShellPkg: Assign the correct value to ShellStatus
> >
> > Since the type of ShellStatus is SHELL_STATUS, we should use
> > SHELL_INVALID_PARAMETER instead of EFI_INVALID_PARAMETER.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Gary Lin <glin@suse.com>
> > Cc: Zhang Lubo <lubo.zhang@intel.com>
> > Cc: Ye Ting <ting.ye@intel.com>
> > Cc: Fu Siyuan <siyuan.fu@intel.com>
> > Cc: Wu Jiaxin <jiaxin.wu@intel.com>
> > ---
> >  ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
> > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
> > index fb308cc3b6..d71688ed66 100644
> > --- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
> > +++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
> > @@ -1319,15 +1319,15 @@ IfConfig6SetInterfaceInfo (
> >
> >        if (StrCmp (VarArg->Arg, L"host") == 0) {
> >          ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN
> > (STR_IFCONFIG6_ERR_INVALID_IP_CONFIG), gShellNetwork2HiiHandle,
> Status);
> > -        ShellStatus = EFI_INVALID_PARAMETER;
> > +        ShellStatus = SHELL_INVALID_PARAMETER;
> >          goto ON_EXIT;
> >        } else if (StrCmp (VarArg->Arg, L"gw") == 0) {
> >          ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN
> > (STR_IFCONFIG6_ERR_INVALID_GW_CONFIG), gShellNetwork2HiiHandle,
> Status);
> > -        ShellStatus = EFI_INVALID_PARAMETER;
> > +        ShellStatus = SHELL_INVALID_PARAMETER;
> >          goto ON_EXIT;
> >        } else if (StrCmp (VarArg->Arg, L"dns") == 0) {
> >          ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN
> > (STR_IFCONFIG6_ERR_INVALID_DNS_CONFIG), gShellNetwork2HiiHandle,
> Status);
> > -        ShellStatus = EFI_INVALID_PARAMETER;
> > +        ShellStatus = SHELL_INVALID_PARAMETER;
> >          goto ON_EXIT;
> >        }
> >
> > --
> > 2.11.0
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2016-12-07 17:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-07  3:40 [PATCH] ShellPkg: Assign the correct value to ShellStatus Gary Lin
2016-12-07  3:45 ` Zhang, Lubo
2016-12-07  7:48 ` Ye, Ting
2016-12-07  9:20 ` Fu, Siyuan
2016-12-07 17:01   ` Carsey, Jaben [this message]
2016-12-08  0:56 ` Wu, Jiaxin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CB6E33457884FA40993F35157061515C54B0CE24@FMSMSX103.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox