From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EC7AF81F16 for ; Wed, 7 Dec 2016 09:01:57 -0800 (PST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP; 07 Dec 2016 09:01:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,310,1477983600"; d="scan'208";a="795370575" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 07 Dec 2016 09:01:57 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 7 Dec 2016 09:01:57 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.12]) by FMSMSX153.amr.corp.intel.com ([169.254.9.101]) with mapi id 14.03.0248.002; Wed, 7 Dec 2016 09:01:57 -0800 From: "Carsey, Jaben" To: "Fu, Siyuan" , Gary Lin , "edk2-devel@lists.01.org" CC: "Ye, Ting" , "Zhang, Lubo" , "Wu, Jiaxin" , "Carsey, Jaben" Thread-Topic: [edk2] [PATCH] ShellPkg: Assign the correct value to ShellStatus Thread-Index: AQHSUDvV7VknFsPTDkKjVBkU1nJLUKD8u+wA///608A= Date: Wed, 7 Dec 2016 17:01:56 +0000 Message-ID: References: <20161207034051.12723-1-glin@suse.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODIxMGE1YWEtMzA3Yi00YzExLTgzZWQtNTYzNjdiOGI5Mjk2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjFuOGhPaEJmWHpITVhXb1RLcG0zNWx2WjBEYWdHQ3FQQkFnbWN0RFJaTkk9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg: Assign the correct value to ShellStatus X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2016 17:01:58 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fu= , > Siyuan > Sent: Wednesday, December 07, 2016 1:20 AM > To: Gary Lin ; edk2-devel@lists.01.org > Cc: Ye, Ting ; Zhang, Lubo ; Wu, > Jiaxin > Subject: Re: [edk2] [PATCH] ShellPkg: Assign the correct value to ShellSt= atus > Importance: High >=20 > Reviewed-by: Fu Siyuan >=20 >=20 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Gary Lin > > Sent: Wednesday, December 7, 2016 11:41 AM > > To: edk2-devel@lists.01.org > > Cc: Ye, Ting ; Zhang, Lubo ; > Fu, > > Siyuan ; Wu, Jiaxin > > Subject: [edk2] [PATCH] ShellPkg: Assign the correct value to ShellStat= us > > > > Since the type of ShellStatus is SHELL_STATUS, we should use > > SHELL_INVALID_PARAMETER instead of EFI_INVALID_PARAMETER. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Gary Lin > > Cc: Zhang Lubo > > Cc: Ye Ting > > Cc: Fu Siyuan > > Cc: Wu Jiaxin > > --- > > ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c > > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c > > index fb308cc3b6..d71688ed66 100644 > > --- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c > > +++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c > > @@ -1319,15 +1319,15 @@ IfConfig6SetInterfaceInfo ( > > > > if (StrCmp (VarArg->Arg, L"host") =3D=3D 0) { > > ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN > > (STR_IFCONFIG6_ERR_INVALID_IP_CONFIG), gShellNetwork2HiiHandle, > Status); > > - ShellStatus =3D EFI_INVALID_PARAMETER; > > + ShellStatus =3D SHELL_INVALID_PARAMETER; > > goto ON_EXIT; > > } else if (StrCmp (VarArg->Arg, L"gw") =3D=3D 0) { > > ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN > > (STR_IFCONFIG6_ERR_INVALID_GW_CONFIG), gShellNetwork2HiiHandle, > Status); > > - ShellStatus =3D EFI_INVALID_PARAMETER; > > + ShellStatus =3D SHELL_INVALID_PARAMETER; > > goto ON_EXIT; > > } else if (StrCmp (VarArg->Arg, L"dns") =3D=3D 0) { > > ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN > > (STR_IFCONFIG6_ERR_INVALID_DNS_CONFIG), gShellNetwork2HiiHandle, > Status); > > - ShellStatus =3D EFI_INVALID_PARAMETER; > > + ShellStatus =3D SHELL_INVALID_PARAMETER; > > goto ON_EXIT; > > } > > > > -- > > 2.11.0 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel