From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: Tapan Shah <tapandshah@hpe.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"Carsey, Jaben" <jaben.carsey@intel.com>
Subject: Re: [PATCH] ShellPkg: Add missing header line for SFO flag in 'cls' command
Date: Thu, 8 Dec 2016 22:07:07 +0000 [thread overview]
Message-ID: <CB6E33457884FA40993F35157061515C54B0EB03@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <1481217671-10440-1-git-send-email-tapandshah@hpe.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Ray, can you push with your other stuff?
> -----Original Message-----
> From: Tapan Shah [mailto:tapandshah@hpe.com]
> Sent: Thursday, December 8, 2016 9:21 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Tapan Shah
> <tapandshah@hpe.com>
> Subject: [PATCH] ShellPkg: Add missing header line for SFO flag in 'cls' command
> Importance: High
>
> Adding a missing header line for 'cls -sfo' command
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Tapan Shah <tapandshah@hpe.com>
> ---
> ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c | 1 +
> .../Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.uni | 1
> +
> 2 files changed, 2 insertions(+)
>
> diff --git a/ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c
> b/ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c
> index de79b82..7e7d58d 100644
> --- a/ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c
> +++ b/ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c
> @@ -82,6 +82,7 @@ ShellCommandRunCls (
> } else {
> Background = (gST->ConOut->Mode->Attribute >> 4) & 0x7;
> Foreground = gST->ConOut->Mode->Attribute & 0x0F;
> + ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_GEN_SFO_HEADER),
> gShellLevel3HiiHandle, L"cls");
> ShellPrintHiiEx (
> -1,
> -1,
> diff --git
> a/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.
> uni
> b/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.
> uni
> index bbcb752..b027c67 100644
> ---
> a/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.
> uni
> +++
> b/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.
> uni
> @@ -43,6 +43,7 @@
> #string STR_GEN_DIR_NF #language en-US "%H%s%N: Directory not
> found - '%H%s%N'\r\n"
> #string STR_GEN_FILE_NF #language en-US "%H%s%N: File not found -
> '%H%s%N'\r\n"
> #string STR_GEN_IS_DIR #language en-US "%H%s%N: '%H%s%N' is a
> directory\r\n"
> +#string STR_GEN_SFO_HEADER #language en-US "ShellCommand,"%s"\r\n"
> #string STR_NO_SCRIPT #language en-US "The command '%H%s%N' is
> not allowed outside of a script\r\n"
>
> #string STR_TYP_ERROR #language en-US "%H%s%N: Operation was not
> successful on '%H%s%N'\r\n"
> --
> 1.9.5.msysgit.0
next prev parent reply other threads:[~2016-12-08 22:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 17:21 [PATCH] ShellPkg: Add missing header line for SFO flag in 'cls' command Tapan Shah
2016-12-08 22:07 ` Carsey, Jaben [this message]
2016-12-09 1:35 ` Ni, Ruiyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB6E33457884FA40993F35157061515C54B0EB03@FMSMSX103.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox