From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 31E2081F52 for ; Thu, 8 Dec 2016 14:07:09 -0800 (PST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP; 08 Dec 2016 14:07:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,321,1477983600"; d="scan'208";a="795895499" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 08 Dec 2016 14:07:08 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 8 Dec 2016 14:07:08 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.12]) by FMSMSX155.amr.corp.intel.com ([169.254.5.221]) with mapi id 14.03.0248.002; Thu, 8 Dec 2016 14:07:08 -0800 From: "Carsey, Jaben" To: Tapan Shah , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Carsey, Jaben" Thread-Topic: [PATCH] ShellPkg: Add missing header line for SFO flag in 'cls' command Thread-Index: AQHSUXeDfOgY4JaRd0eisxK+zncgEKD+m7DA Date: Thu, 8 Dec 2016 22:07:07 +0000 Message-ID: References: <1481217671-10440-1-git-send-email-tapandshah@hpe.com> In-Reply-To: <1481217671-10440-1-git-send-email-tapandshah@hpe.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg: Add missing header line for SFO flag in 'cls' command X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Dec 2016 22:07:09 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey Ray, can you push with your other stuff? > -----Original Message----- > From: Tapan Shah [mailto:tapandshah@hpe.com] > Sent: Thursday, December 8, 2016 9:21 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Tapan Shah > > Subject: [PATCH] ShellPkg: Add missing header line for SFO flag in 'cls' = command > Importance: High >=20 > Adding a missing header line for 'cls -sfo' command >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Tapan Shah > --- > ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c = | 1 + > .../Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.uni = | 1 > + > 2 files changed, 2 insertions(+) >=20 > diff --git a/ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c > b/ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c > index de79b82..7e7d58d 100644 > --- a/ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c > +++ b/ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c > @@ -82,6 +82,7 @@ ShellCommandRunCls ( > } else { > Background =3D (gST->ConOut->Mode->Attribute >> 4) & 0x7; > Foreground =3D gST->ConOut->Mode->Attribute & 0x0F; > + ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_GEN_SFO_HEADER)= , > gShellLevel3HiiHandle, L"cls"); > ShellPrintHiiEx ( > -1, > -1, > diff --git > a/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib. > uni > b/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib. > uni > index bbcb752..b027c67 100644 > --- > a/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib. > uni > +++ > b/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib. > uni > @@ -43,6 +43,7 @@ > #string STR_GEN_DIR_NF #language en-US "%H%s%N: Directory not > found - '%H%s%N'\r\n" > #string STR_GEN_FILE_NF #language en-US "%H%s%N: File not foun= d - > '%H%s%N'\r\n" > #string STR_GEN_IS_DIR #language en-US "%H%s%N: '%H%s%N' is a > directory\r\n" > +#string STR_GEN_SFO_HEADER #language en-US "ShellCommand,"%s"\r\n= " > #string STR_NO_SCRIPT #language en-US "The command '%H%s%N' = is > not allowed outside of a script\r\n" >=20 > #string STR_TYP_ERROR #language en-US "%H%s%N: Operation was= not > successful on '%H%s%N'\r\n" > -- > 1.9.5.msysgit.0