Re: [patch 01/18] ShellPkg/UefiShellDebug1CommandsLib: Fix coding style issues

["Carsey, Jaben" <jaben.carsey@intel.com>]

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Tuesday, December 13, 2016 12:40 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [edk2] [patch 01/18] ShellPkg/UefiShellDebug1CommandsLib: Fix
> coding style issues
> Importance: High
> 
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
> index 7133881..bb2c0b9 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
> @@ -82,12 +82,12 @@ GetAttrType (
>  }
> 
>  /**
>    Convert binary to hex format string.
> 
> -  @param[in]  BufferSize        The size in bytes of the binary data.
>    @param[in]  Buffer            The binary data.
> +  @param[in]  BufferSize        The size in bytes of the binary data.
>    @param[in, out] HexString     Hex format string.
>    @param[in]      HexStringSize The size in bytes of the string.
> 
>    @return The hex format string.
>  **/
> @@ -421,10 +421,11 @@ CascadeProcessVariables (
>    UINT32                    Atts;
>    SHELL_STATUS              ShellStatus;
>    UINTN                     NameSize;
>    CHAR16                    *AttrString;
>    CHAR16                    *HexString;
> +  EFI_STATUS                SetStatus;
> 
>    if (ShellGetExecutionBreakFlag()) {
>      return (SHELL_ABORTED);
>    }
> 
> @@ -546,11 +547,11 @@ CascadeProcessVariables (
>        }
>      } else if (Type == DmpStoreDelete) {
>        //
>        // We only need name to delete it...
>        //
> -      EFI_STATUS SetStatus = gRT->SetVariable (FoundVarName,
> &FoundVarGuid, Atts, 0, NULL);
> +      SetStatus = gRT->SetVariable (FoundVarName, &FoundVarGuid, Atts, 0,
> NULL);
>        if (StandardFormatOutput) {
>          if (SetStatus == EFI_SUCCESS) {
>            ShellPrintHiiEx (
>              -1, -1, NULL, STRING_TOKEN
> (STR_DMPSTORE_NO_VAR_FOUND_NG_SFO), gShellDebug1HiiHandle,
>              FoundVarName, &FoundVarGuid
> --
> 1.9.5.msysgit.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel