From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 81857821C5 for ; Tue, 13 Dec 2016 08:16:42 -0800 (PST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP; 13 Dec 2016 08:16:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,342,1477983600"; d="scan'208";a="17553648" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 13 Dec 2016 08:16:41 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.47]) by FMSMSX108.amr.corp.intel.com ([169.254.9.109]) with mapi id 14.03.0248.002; Tue, 13 Dec 2016 08:16:41 -0800 From: "Carsey, Jaben" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Carsey, Jaben" Thread-Topic: [edk2] [patch 01/18] ShellPkg/UefiShellDebug1CommandsLib: Fix coding style issues Thread-Index: AQHSVRzMO3xBcKHD9Eus4gseRDasOKEGDlbA Date: Tue, 13 Dec 2016 16:16:41 +0000 Message-ID: References: <1481618428-101904-1-git-send-email-dandan.bi@intel.com> <1481618428-101904-2-git-send-email-dandan.bi@intel.com> In-Reply-To: <1481618428-101904-2-git-send-email-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDFlYTg1ZDctM2YyZi00NTc0LWEyZWItYmJjYzkxYjM3NmM1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkF0aTMwakp2WUFLYU1RSkVVdlJFTEZmK1paa0phTTdBUEd6WnJmZWtWYlE9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [patch 01/18] ShellPkg/UefiShellDebug1CommandsLib: Fix coding style issues X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Dec 2016 16:16:42 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Dandan Bi > Sent: Tuesday, December 13, 2016 12:40 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: [edk2] [patch 01/18] ShellPkg/UefiShellDebug1CommandsLib: Fix > coding style issues > Importance: High >=20 > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi > --- > ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > index 7133881..bb2c0b9 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > @@ -82,12 +82,12 @@ GetAttrType ( > } >=20 > /** > Convert binary to hex format string. >=20 > - @param[in] BufferSize The size in bytes of the binary data. > @param[in] Buffer The binary data. > + @param[in] BufferSize The size in bytes of the binary data. > @param[in, out] HexString Hex format string. > @param[in] HexStringSize The size in bytes of the string. >=20 > @return The hex format string. > **/ > @@ -421,10 +421,11 @@ CascadeProcessVariables ( > UINT32 Atts; > SHELL_STATUS ShellStatus; > UINTN NameSize; > CHAR16 *AttrString; > CHAR16 *HexString; > + EFI_STATUS SetStatus; >=20 > if (ShellGetExecutionBreakFlag()) { > return (SHELL_ABORTED); > } >=20 > @@ -546,11 +547,11 @@ CascadeProcessVariables ( > } > } else if (Type =3D=3D DmpStoreDelete) { > // > // We only need name to delete it... > // > - EFI_STATUS SetStatus =3D gRT->SetVariable (FoundVarName, > &FoundVarGuid, Atts, 0, NULL); > + SetStatus =3D gRT->SetVariable (FoundVarName, &FoundVarGuid, Atts,= 0, > NULL); > if (StandardFormatOutput) { > if (SetStatus =3D=3D EFI_SUCCESS) { > ShellPrintHiiEx ( > -1, -1, NULL, STRING_TOKEN > (STR_DMPSTORE_NO_VAR_FOUND_NG_SFO), gShellDebug1HiiHandle, > FoundVarName, &FoundVarGuid > -- > 1.9.5.msysgit.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel