From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Carsey, Jaben" <jaben.carsey@intel.com>
Subject: Re: [PATCH] ShellPkg/setvar: Correct typo in setvar help message
Date: Thu, 15 Dec 2016 16:49:05 +0000 [thread overview]
Message-ID: <CB6E33457884FA40993F35157061515C54B26B2F@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <20161215072917.202560-1-ruiyu.ni@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Wednesday, December 14, 2016 11:29 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>
> Subject: [PATCH] ShellPkg/setvar: Correct typo in setvar help message
> Importance: High
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> ---
> .../UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni | 6
> +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi
> b.uni
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi
> b.uni
> index bd1726b..06865a4 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi
> b.uni
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi
> b.uni
> @@ -813,9 +813,9 @@
> " 3. If = is not specified, then the current variable contents are displayed.\r\n"
> " 4. If =data is specified, then the variable's value is changed to the value\r\n"
> " specified by data.\r\n"
> -" 5. -bs, -rt and -nv are only useful if the variable already exists.\r\n"
> -" 6. If the variable already exists and the attributes cannot be changed,\r\n"
> -" then -1 is returned. \r\n"
> +" 5. -bs, -rt and -nv are only useful if the variable does not exist.\r\n"
> +" 6. If the variable already exists, the attributes cannot be changed, and the"
> +" flags will be ignored.\r\n"
> ".SH RETURNVALUES\r\n"
> " \r\n"
> "RETURN VALUES:\r\n"
> --
> 2.9.0.windows.1
prev parent reply other threads:[~2016-12-15 16:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 7:29 [PATCH] ShellPkg/setvar: Correct typo in setvar help message Ruiyu Ni
2016-12-15 16:49 ` Carsey, Jaben [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB6E33457884FA40993F35157061515C54B26B2F@FMSMSX103.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox