From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4BC9D820B6 for ; Mon, 19 Dec 2016 10:01:22 -0800 (PST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP; 19 Dec 2016 10:01:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,374,1477983600"; d="scan'208";a="204627634" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 19 Dec 2016 10:01:21 -0800 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 19 Dec 2016 10:01:21 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.47]) by FMSMSX126.amr.corp.intel.com ([169.254.1.42]) with mapi id 14.03.0248.002; Mon, 19 Dec 2016 10:01:21 -0800 From: "Carsey, Jaben" To: Evan Lloyd , "Ni, Ruiyu" , "edk2-devel@ml01.01.org" CC: Leif Lindholm , "ard.biesheuvel@linaro.org" , "Carsey, Jaben" Thread-Topic: [edk2] [PATCH] ShellPkg: Add acpiview tool to dump ACPI tables Thread-Index: AQHSV8nfXsTruQndP0qGhbgB9u91oqEPkLIAgABm9wD//5xQEA== Date: Mon, 19 Dec 2016 18:01:21 +0000 Message-ID: References: <20161216182547.616-1-evan.lloyd@arm.com> <734D49CCEBEEF84792F5B80ED585239D5B836C04@SHSMSX103.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzg1ZmM2NzEtZjAwOC00Mzg3LWI5NzgtZTgyNWRkMDNhYjk3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkNSUGw4dHhRVURXNGR2cFRYZkt4VkVVaExBeHVzTkNybDZjZ05hZTV6c3M9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg: Add acpiview tool to dump ACPI tables X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Dec 2016 18:01:22 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I am good with this addition. The BSD is a huge advantage for me. Reviewed-by: Jaben Carsey I will allow Ray to resolve any issues he and push it. -Jaben > -----Original Message----- > From: Evan Lloyd [mailto:Evan.Lloyd@arm.com] > Sent: Monday, December 19, 2016 7:57 AM > To: Ni, Ruiyu ; edk2-devel@ml01.01.org > Cc: Carsey, Jaben ; Leif Lindholm > ; ard.biesheuvel@linaro.org > Subject: RE: [edk2] [PATCH] ShellPkg: Add acpiview tool to dump ACPI tabl= es > Importance: High >=20 > Hi Ray. > Good question. Answer inline. >=20 > >-----Original Message----- > >From: Ni, Ruiyu [mailto:ruiyu.ni@intel.com] > >Sent: 19 December 2016 09:49 > >To: Evan Lloyd; edk2-devel@ml01.01.org > >Cc: Carsey, Jaben; Leif Lindholm; ard.biesheuvel@linaro.org > >Subject: RE: [edk2] [PATCH] ShellPkg: Add acpiview tool to dump ACPI > >tables > > > >I happened to find another version of acpi dump tool in shell. > >Binary can be downloaded from: https://acpica.org/downloads/uefi- > >support > >Source can be downloaded from: https://github.com/acpica/acpica > > > >Are there any differences between the above one and yours? >=20 > The main differences are: > 1.acpiview provides a formatted dump of non-AML tables at the Shell level= . > This provides the equivalent of using acpidump -b, then transferring the= file > to use "iasl -d" on another system. However, it works on systems where t= he > tables do not yet enable an OS to boot, or have limited disk functionalit= y. > 2.It provides a small amount of specification consistency checking/error > reporting at the Shell level. We have found that to be an invaluable aid= to > debugging. > 3.It has a normal UEFI BSD license, so doesn't instigate legal anxiety. >=20 > Regards, > Evan >=20 >=20 > > > >Thanks/Ray > > > >> -----Original Message----- > >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > >> evan.lloyd@arm.com > >> Sent: Saturday, December 17, 2016 2:26 AM > >> To: edk2-devel@ml01.01.org > >> Cc: Carsey, Jaben ; Ni, Ruiyu > >; > >> Leif Lindholm ; Ard Biesheuvel > >> > >> Subject: [edk2] [PATCH] ShellPkg: Add acpiview tool to dump ACPI table= s > >> > >> From: Sami Mujawar > >> > >> This program is provided to allow examination of ACPI table contents > >> from the UEFI Shell. This can help with investigations, especially at > >> that stage where the tables are not enabling an OS to boot. > >> The program is not exhaustive, and only encapsulates detailed knowledg= e > >> of a limited number of table types. > >> > >> Default behaviour is to display the content of all tables installed. > >> 'Known' table types will be parsed and displayed with descriptions and > >> field values. Where appropriate a degree of consistency checking is > >> done and errors may be reported in the output. > >> Other table types will be displayed as an array of Hexadecimal bytes. > >> > >> To facilitate debugging, the -t and -b options can be used to generate= a > >> binary file image of a table that can be copied elsewhere for > >> investigation using tools such as those provided by acpica.org. This = is > >> especially relevant for AML type tables like DSDT and SSDT. > >> > >> The inspiration for this is the existing smbiosview Debug1 Shell > >> command, and the command is also intended for Debug1. > >> > >> Many tables are not explicitly handled, in part because no examples ar= e > >> available for our testing. > >> > >> The program is designed to be extended to new tables with minimal > >> effort, and contributions are invited. > >> > >> The code is available for examination at: > >> https://github.com/EvanLloyd/tianocore/tree/651_acpiview_v1 > >> > >> Contributed-under: TianoCore Contribution Agreement 1.0 > >> Signed-off-by: Sami Mujawar > >> Signed-off-by: Evan Lloyd > >> --- > >> ShellPkg/ShellPkg.dec = | 2 + > >> > >> > ... > >> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") > >> > >> _______________________________________________ > >> edk2-devel mailing list > >> edk2-devel@lists.01.org > >> https://lists.01.org/mailman/listinfo/edk2-devel > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended reci= pient, > please notify the sender immediately and do not disclose the contents to = any > other person, use it for any purpose, or store or copy the information in= any > medium. Thank you.