From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 71ECA81AD5 for ; Mon, 9 Jan 2017 07:40:35 -0800 (PST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP; 09 Jan 2017 07:40:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,340,1477983600"; d="scan'208";a="47117754" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga004.jf.intel.com with ESMTP; 09 Jan 2017 07:40:34 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.47]) by FMSMSX106.amr.corp.intel.com ([10.18.124.204]) with mapi id 14.03.0248.002; Mon, 9 Jan 2017 07:40:34 -0800 From: "Carsey, Jaben" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: "Carsey, Jaben" Thread-Topic: [edk2] [PATCH 0/5] Change "dh" to support dump from GUID and "decode" parameter Thread-Index: AQHSals5VUjt7sOhxk+2YWup8a4/VqEwSGBw Date: Mon, 9 Jan 2017 15:40:32 +0000 Message-ID: References: <20170109093052.140504-1-ruiyu.ni@intel.com> In-Reply-To: <20170109093052.140504-1-ruiyu.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Subject: Re: [PATCH 0/5] Change "dh" to support dump from GUID and "decode" parameter X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2017 15:40:35 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Looks good. Reviewed-by: Jaben Carsey I had one inline question. I would also propose that the String to GUID conversion be placed in a shar= ed library. Maybe even baselib with the other string functions?=20 Mike, do you have any thoughts on StringToGuid conversion? > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ru= iyu > Ni > Sent: Monday, January 9, 2017 1:31 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 0/5] Change "dh" to support dump from GUID and > "decode" parameter > Importance: High >=20 > Change "dh" to support dump from GUID and "decode" parameter >=20 > Chen A Chen (2): > ShellPkg/HandleParsingLib: Add new API GetAllMappingGuids > ShellPkg/Dh: Fix coding style issues >=20 > Ruiyu Ni (3): > ShellPkg/HandleParsingLib: Rename global variables > ShellPkg/HandleParsingLib: Return NULL name for unknown GUID > ShellPkg/dh: Support dump from GUID and "decode" parameter >=20 > ShellPkg/Include/Library/HandleParsingLib.h | 21 +- > .../UefiHandleParsingLib/UefiHandleParsingLib.c | 130 ++++-- > .../UefiHandleParsingLib/UefiHandleParsingLib.uni | 4 +- > ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c | 458 +++++++++++++++= -- > ---- > .../UefiShellDriver1CommandsLib.uni | 9 +- > 5 files changed, 446 insertions(+), 176 deletions(-) >=20 > -- > 2.9.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel