public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
	"Carsey, Jaben" <jaben.carsey@intel.com>
Subject: Re: [patch] ShellPkg/HandleParsingLib: Fix coding style issue
Date: Wed, 18 Jan 2017 21:27:39 +0000	[thread overview]
Message-ID: <CB6E33457884FA40993F35157061515C54B499A9@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <1484532214-124596-1-git-send-email-dandan.bi@intel.com>

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: Bi, Dandan
> Sent: Sunday, January 15, 2017 6:04 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [patch] ShellPkg/HandleParsingLib: Fix coding style issue
> Importance: High
> 
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  ShellPkg/Include/Library/HandleParsingLib.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ShellPkg/Include/Library/HandleParsingLib.h
> b/ShellPkg/Include/Library/HandleParsingLib.h
> index b02cf4f..6416128 100644
> --- a/ShellPkg/Include/Library/HandleParsingLib.h
> +++ b/ShellPkg/Include/Library/HandleParsingLib.h
> @@ -390,12 +390,12 @@ GetHandleListByProtocolList (
> 
> 
>  /**
>    Return all supported GUIDs.
> 
> -  @param[out]     Guids  The buffer to return all supported GUIDs.
> -  @param[in out]  Count  On input, the count of GUIDs the buffer can hold,
> +  @param[out]      Guids  The buffer to return all supported GUIDs.
> +  @param[in, out]  Count  On input, the count of GUIDs the buffer can hold,
>                           On output, the count of GUIDs to return.
> 
>    @retval EFI_INVALID_PARAMETER Count is NULL.
>    @retval EFI_BUFFER_TOO_SMALL  Buffer is not enough to hold all GUIDs.
>    @retval EFI_SUCCESS           GUIDs are returned successfully.
> --
> 1.9.5.msysgit.1



      reply	other threads:[~2017-01-18 21:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-16  2:03 [patch] ShellPkg/HandleParsingLib: Fix coding style issue Dandan Bi
2017-01-18 21:27 ` Carsey, Jaben [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CB6E33457884FA40993F35157061515C54B499A9@FMSMSX103.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox