From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4698281E5C for ; Wed, 18 Jan 2017 16:55:45 -0800 (PST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP; 18 Jan 2017 16:55:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,251,1477983600"; d="scan'208";a="215040073" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 18 Jan 2017 16:55:44 -0800 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 18 Jan 2017 16:55:44 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.47]) by FMSMSX125.amr.corp.intel.com ([169.254.2.191]) with mapi id 14.03.0248.002; Wed, 18 Jan 2017 16:55:44 -0800 From: "Carsey, Jaben" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Carsey, Jaben" Thread-Topic: [PATCH] ShellPkg SmbiosView: Add missing decoding of SlotType AGP8X Thread-Index: AQHScHEUjzL24aA7I0GNswWO7vzOQqE+/J1Q Date: Thu, 19 Jan 2017 00:55:44 +0000 Message-ID: References: <1484623395-179204-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1484623395-179204-1-git-send-email-star.zeng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg SmbiosView: Add missing decoding of SlotType AGP8X X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jan 2017 00:55:45 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: Zeng, Star > Sent: Monday, January 16, 2017 7:23 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Carsey, Jaben ; > Ni, Ruiyu > Subject: [PATCH] ShellPkg SmbiosView: Add missing decoding of SlotType AG= P8X >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D344 >=20 > SlotType AGP8X was added in SMBIOS spec 2.3.4, but the decoding of it is > missing. I found it when I am adding SMBIOS spec 3.1.0 support. >=20 > Cc: Jaben Carsey > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Star Zeng > --- > ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c | 6 > +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c > index b802c5450907..bb7a19b04170 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > +++ c > @@ -2,7 +2,7 @@ > Build a table, each item is (Key, Info) pair. > And give a interface of query a string out of a table. >=20 > - Copyright (c) 2005 - 2015, Intel Corporation. All rights reserved.
> + Copyright (c) 2005 - 2017, Intel Corporation. All rights > + reserved.
> (C) Copyright 2016-2017 Hewlett Packard Enterprise Development LP
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the = BSD > License @@ -1263,6 +1263,10 @@ TABLE_ITEM SystemSlotTypeTable[] =3D { > L"PCI-X" > }, > { > + 0x13, > + L"AGP 8X" > + }, > + { > 0xA0, > L"PC-98/C20 " > }, > -- > 2.7.0.windows.1