public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Chris J Phillips <chrisp@hpe.com>,
	Tapan Shah <tapandshah@hpe.com>,
	"Carsey, Jaben" <jaben.carsey@intel.com>
Subject: Re: [PATCH] ShellPkg/cd: Do not print the destination dir when CD exits
Date: Thu, 26 Jan 2017 16:59:41 +0000	[thread overview]
Message-ID: <CB6E33457884FA40993F35157061515C54B546BA@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <20170126043407.357464-1-ruiyu.ni@intel.com>

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Wednesday, January 25, 2017 8:34 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Chris J Phillips
> <chrisp@hpe.com>; Tapan Shah <tapandshah@hpe.com>
> Subject: [PATCH] ShellPkg/cd: Do not print the destination dir when CD exits
> Importance: High
> 
> Before the "cd fs0:dir" fix, CD only prints destination directory
> when the destination contains ":".
> However, the "cd fs0:dir" fix changed CD to always print destination
> directory.
> 
> This patch changes CD to never print destination directory.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Chris J Phillips <chrisp@hpe.com>
> Cc: Tapan Shah <tapandshah@hpe.com>
> ---
>  ShellPkg/Library/UefiShellLevel2CommandsLib/Cd.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Cd.c
> b/ShellPkg/Library/UefiShellLevel2CommandsLib/Cd.c
> index d459a7a..dd4a740 100644
> --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Cd.c
> +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Cd.c
> @@ -3,7 +3,7 @@
> 
>    (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
>    (C) Copyright 2015 Hewlett-Packard Development Company, L.P.<BR>
> -  Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved.<BR>
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of the BSD
> License
>    which accompanies this distribution.  The full text of the license may be
> found at
> @@ -321,8 +321,6 @@ ShellCommandRunCd (
>              if (EFI_ERROR (Status)) {
>                ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN(STR_GEN_DIR_NF),
> gShellLevel2HiiHandle, L"cd", Param1Copy);
>                ShellStatus = SHELL_NOT_FOUND;
> -            } else {
> -              ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN(STR_CD_PRINT),
> gShellLevel2HiiHandle, ShellGetCurrentDir(Drive));
>              }
>            }
>          }
> --
> 2.9.0.windows.1



      parent reply	other threads:[~2017-01-26 16:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-26  4:34 [PATCH] ShellPkg/cd: Do not print the destination dir when CD exits Ruiyu Ni
2017-01-26 14:51 ` Shah, Tapan
2017-01-26 16:59 ` Carsey, Jaben [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CB6E33457884FA40993F35157061515C54B546BA@FMSMSX103.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox