From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F31F1820AD for ; Fri, 3 Feb 2017 09:45:37 -0800 (PST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP; 03 Feb 2017 09:45:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,329,1477983600"; d="scan'208";a="39376205" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 03 Feb 2017 09:45:37 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 3 Feb 2017 09:45:36 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.47]) by fmsmsx156.amr.corp.intel.com ([169.254.13.248]) with mapi id 14.03.0248.002; Fri, 3 Feb 2017 09:45:36 -0800 From: "Carsey, Jaben" To: "Ni, Ruiyu" , Thomas Palmer , "edk2-devel@lists.01.org" CC: "Carsey, Jaben" Thread-Topic: [edk2] [PATCH 1/1] ShellPkg/UefiShellLevel2CommandsLib: Fix "cp" for GCC systems Thread-Index: AQHSfDw2BLLi5T2ZX0mHu5i9ZSOoH6FXdmEAgAAbx+A= Date: Fri, 3 Feb 2017 17:45:35 +0000 Message-ID: References: <1485920100-33234-1-git-send-email-thomas.palmer@hpe.com> <734D49CCEBEEF84792F5B80ED585239D5B893036@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5B893036@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Subject: Re: [PATCH 1/1] ShellPkg/UefiShellLevel2CommandsLib: Fix "cp" for GCC systems X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2017 17:45:38 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ni= , > Ruiyu > Sent: Friday, February 3, 2017 12:06 AM > To: Thomas Palmer ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH 1/1] ShellPkg/UefiShellLevel2CommandsLib: Fix = "cp" > for GCC systems > Importance: High >=20 > Reviewed-by: Ruiyu Ni >=20 > Regards, > Ray >=20 > >-----Original Message----- > >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > >Thomas Palmer > >Sent: Wednesday, February 1, 2017 11:35 AM > >To: edk2-devel@lists.01.org > >Cc: Ni, Ruiyu > >Subject: [edk2] [PATCH 1/1] ShellPkg/UefiShellLevel2CommandsLib: Fix > >"cp" for GCC systems > > > >On GCC built UEFIs, the "cp" command fails with "The source and > >destination are the same". > > > >The root cause is that StrniCmp failed to detect a case- insensitive > >string difference due to the InternalCharToUpper function being > >improperly declared. > > > >Fix is to add missing EFIAPI token to match the original > >implementation. > > > >Contributed-under: TianoCore Contribution Agreement 1.0 > >Signed-off-by: Thomas Palmer > >--- > > .../Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.c = | 2 > ++ > > 1 file changed, 2 insertions(+) > > > >diff --git > >a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLi > >b.c > >b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLi > >b.c index 7948e53cfc46..4dbff4de26f8 100644 > >--- > >a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLi > >b.c > >+++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Comman > >+++ dsLib.c > >@@ -21,6 +21,7 @@ > > > > * functions are non-interactive only > > > >+ (C) Copyright 2017 Hewlett Packard Enterprise Development LP
> > Copyright (c) 2014 Hewlett-Packard Development Company, L.P. > > Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved. > > This program and the accompanying materials @@ -268,6 +269,7 @@ > >VerifyIntermediateDirectories ( > > @return Char as an upper case character. > > **/ > > CHAR16 > >+EFIAPI > > InternalCharToUpper ( > > IN CONST CHAR16 Char > > ); > >-- > >2.7.4 > > > >_______________________________________________ > >edk2-devel mailing list > >edk2-devel@lists.01.org > >https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel