From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9CACB820B2 for ; Fri, 3 Feb 2017 09:47:52 -0800 (PST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 03 Feb 2017 09:47:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,329,1477983600"; d="scan'208";a="39376981" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 03 Feb 2017 09:47:52 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 3 Feb 2017 09:47:51 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.47]) by FMSMSX153.amr.corp.intel.com ([169.254.9.17]) with mapi id 14.03.0248.002; Fri, 3 Feb 2017 09:47:51 -0800 From: "Carsey, Jaben" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: Andrew Fish , "Gao, Liming" , "Yao, Jiewen" , "Zeng, Star" , "Carsey, Jaben" Thread-Topic: [edk2] [PATCH v4 0/3] Remove TimerLib dependency from DP Thread-Index: AQHSfdnMKSuVcIKiQkmDnraP+24xU6FXj1+A Date: Fri, 3 Feb 2017 17:47:50 +0000 Message-ID: References: <1486097737-12816-1-git-send-email-michael.d.kinney@intel.com> In-Reply-To: <1486097737-12816-1-git-send-email-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Subject: Re: [PATCH v4 0/3] Remove TimerLib dependency from DP X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2017 17:47:52 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I am good with this change. I like the idea of changing platforms that bui= ld the shell from source in a separate patch series. Reviewed-by: Jaben Carsey > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Michael Kinney > Sent: Thursday, February 2, 2017 8:56 PM > To: edk2-devel@lists.01.org > Cc: Andrew Fish ; Gao, Liming ; Ya= o, > Jiewen ; Carsey, Jaben ; > Zeng, Star > Subject: [edk2] [PATCH v4 0/3] Remove TimerLib dependency from DP > Importance: High >=20 > Current DP implementation depends on TimerLib, as different platforms may > implement and use their own TimerLib, it makes the dp needs to be built b= y > platform. The TimerLib dependency can be removed by using performance > property configuration table to make DP to be generic. >=20 > There was a discussion on edk2-devel about supporting use of different Ti= merLib > instances in different modules and updating the performance log to suppor= t > measurements with different timer rates. A complete solution for this ha= s not > been found. >=20 > This patch series that allows the DP command to get the timer rate from a > system configuration table is useful on its own because it allows the DP = shell > command to be independent of the TimerLib used to collect the performance > logs. >=20 > V3: > Define and install performance property configuration table instead of > extending PEI performance log HOB. As user may want to only dump DXE or > SMM performance data, then PeiPerformanceLib will be not linked and PEI > performance log HOB will be not built. >=20 > V4: > Change name of field in PERFORMANCE_PROPERTY from CpuFreq to Frequency. >=20 > Cc: Andrew Fish > Cc: Michael Kinney > Cc: Liming Gao > Cc: Jiewen Yao > Cc: Cinnamon Shia > Cc: Jaben Carsey > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Star Zeng >=20 > Star Zeng (3): > MdeModulePkg: Add performance property configuration table > PerformancePkg Dp_App: Remove TimerLib dependency > ShellPkg UefiDpLib: Remove TimerLib dependency >=20 > MdeModulePkg/Include/Guid/Performance.h | 12 +++++++- > .../DxeCorePerformanceLib/DxeCorePerformanceLib.c | 23 ++++++++++++-- > .../DxeCorePerformanceLib.inf | 2 ++ > .../DxeCorePerformanceLibInternal.h | 3 +- > .../SmmCorePerformanceLib/SmmCorePerformanceLib.c | 18 +++++++++++ > .../SmmCorePerformanceLib.inf | 5 +++- > PerformancePkg/Dp_App/Dp.c | 35 +++++++++++-----= ------ > PerformancePkg/Dp_App/Dp.inf | 6 ++-- > PerformancePkg/Dp_App/DpInternal.h | 6 ++-- > PerformancePkg/Dp_App/DpProfile.c | 3 +- > PerformancePkg/Dp_App/DpStrings.uni | 10 ++++--- > PerformancePkg/Dp_App/DpTrace.c | 25 ++-------------- > PerformancePkg/Dp_App/DpUtilities.c | 3 +- > PerformancePkg/Dp_App/Literals.c | 3 +- > ShellPkg/Library/UefiDpLib/Dp.c | 29 +++++++---------= -- > ShellPkg/Library/UefiDpLib/DpInternal.h | 6 ++-- > ShellPkg/Library/UefiDpLib/DpProfile.c | 3 +- > ShellPkg/Library/UefiDpLib/DpTrace.c | 25 ++-------------- > ShellPkg/Library/UefiDpLib/DpUtilities.c | 3 +- > ShellPkg/Library/UefiDpLib/Literals.c | 3 +- > ShellPkg/Library/UefiDpLib/UefiDpLib.inf | 6 ++-- > ShellPkg/Library/UefiDpLib/UefiDpLib.uni | 3 +- > ShellPkg/ShellPkg.dsc | 3 +- > 23 files changed, 117 insertions(+), 118 deletions(-) >=20 > -- > 2.6.3.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel