From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <jaben.carsey@intel.com> Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AEA9A82137 for <edk2-devel@lists.01.org>; Fri, 17 Feb 2017 09:38:14 -0800 (PST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Feb 2017 09:38:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,172,1484035200"; d="scan'208";a="59649227" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 17 Feb 2017 09:38:13 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 17 Feb 2017 09:37:59 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.47]) by FMSMSX154.amr.corp.intel.com ([169.254.6.37]) with mapi id 14.03.0248.002; Fri, 17 Feb 2017 09:37:58 -0800 From: "Carsey, Jaben" <jaben.carsey@intel.com> To: "Jim.Dailey@dell.com" <Jim.Dailey@dell.com> CC: "Ni, Ruiyu" <ruiyu.ni@intel.com>, "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>, "jeff.westfahl@ni.com" <jeff.westfahl@ni.com>, "Carsey, Jaben" <jaben.carsey@intel.com> Thread-Topic: [edk2] [PATCH] ShellPkg/HandleParsingLib: Correct format specifier for LoadedImage Thread-Index: AQHShwzsy8lrFMjQHEef5anMn4XB26FpnqeAgAABMwCAAW/5AIAC5UwA//+CfUCAAIj+gP//ekiQ Date: Fri, 17 Feb 2017 17:37:57 +0000 Message-ID: <CB6E33457884FA40993F35157061515C54B762A7@FMSMSX103.amr.corp.intel.com> References: <62a8491631d9dbde89d160ab213d3a16a2e76534.1487107403.git.jeff.westfahl@ni.com> <66fef1ec77c84e188120b733da3d00a9@ausx13mps335.AMER.DELL.COM> <e2ce0ae16a7a4bc0bc1fb7cd122d37df@ausx13mps335.AMER.DELL.COM> <alpine.DEB.2.20.1702151438010.11386@jmw-lm181> <alpine.DEB.2.20.1702171053480.24730@jmw-lm181> <CB6E33457884FA40993F35157061515C54B761FF@FMSMSX103.amr.corp.intel.com> <c0a342b031834dae89bed50924c11baf@ausx13mps335.AMER.DELL.COM> In-Reply-To: <c0a342b031834dae89bed50924c11baf@ausx13mps335.AMER.DELL.COM> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTNhNmYwNWUtMzVjZS00NGYxLWJjOTgtMTJkZjhlMDdlOWJmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IitKU2JaTVQ4TnFGbmdIVlg0MlIyc3lHVkhBNlRnWE8xNUdoOHFnK1dFbE09In0= x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg/HandleParsingLib: Correct format specifier for LoadedImage X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development <edk2-devel.lists.01.org> List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>, <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe> List-Archive: <http://lists.01.org/pipermail/edk2-devel/> List-Post: <mailto:edk2-devel@lists.01.org> List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help> List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>, <mailto:edk2-devel-request@lists.01.org?subject=subscribe> X-List-Received-Date: Fri, 17 Feb 2017 17:38:14 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I think that the long term solution may improve upon this one, but if the d= ata is hex, then printing in hex at all would seem to be the logical first = step. > -----Original Message----- > From: Jim.Dailey@dell.com [mailto:Jim.Dailey@dell.com] > Sent: Friday, February 17, 2017 9:36 AM > To: Carsey, Jaben <jaben.carsey@intel.com> > Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-devel@lists.01.org; > jeff.westfahl@ni.com > Subject: RE: [edk2] [PATCH] ShellPkg/HandleParsingLib: Correct format > specifier for LoadedImage > Importance: High >=20 > My point was that printing one byte of the data as hex is not much better= (as > far > as avoiding the crash is concerned) than simply not printing the data at = all. If > we are just trying to avoid the crash, printing nothing is even simpler. >=20 > If the correct representation is hex bytes, fine; but why print only 1 of= them > and not all of them? >=20 >=20 > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Carsey, Jaben > Sent: Friday, February 17, 2017 11:28 AM > To: Jeff Westfahl <jeff.westfahl@ni.com> > Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben > <jaben.carsey@intel.com>; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] ShellPkg/HandleParsingLib: Correct format > specifier for LoadedImage >=20 > I was reading the email. I was also waiting and making sure there was > consensus since I didn't have a strong opinion. I will let Ray check als= o, but I > think the fix is good. >=20 > Reviewed-by: Jaben Carsey <jaben.carsey@intel.com> >=20 > > -----Original Message----- > > From: Jeff Westfahl [mailto:jeff.westfahl@ni.com] > > Sent: Friday, February 17, 2017 8:55 AM > > To: Jeff Westfahl <jeff.westfahl@ni.com> > > Cc: edk2-devel@lists.01.org; Carsey, Jaben <jaben.carsey@intel.com>; Ni= , > > Ruiyu <ruiyu.ni@intel.com> > > Subject: Re: [edk2] [PATCH] ShellPkg/HandleParsingLib: Correct format > > specifier for LoadedImage > > Importance: High > > > > Jaben, Ruiyu, > > > > Sorry, I forgot to cc you as the ShellPkg maintainers when I submitted > > this patch. > > > > Regards, > > Jeff Westfahl > > > > On Wed, 15 Feb 2017, Jeff Westfahl wrote: > > > > > Jim, > > > > > > I agree that those are good ideas. However, such an implementation > would > > > still crash on a BIOS built against the EDK II before commit 891d844.= I think > > > it might be best to resolve the crash with the simple patch I have ma= de, > > and > > > defer your suggestions for now. > > > > > > Regards, > > > Jeff > > > > > > On Tue, 14 Feb 2017, Jim.Dailey@dell.com wrote: > > > > > >> Please disregard the earlier "Confidential" text. The stupid plug-in= that > > >> adds this > > >> does not show the text in the mail when it is composed in text mode,= so > I > > >> often > > >> forget to turn this "feature" off when posting. Sorry. > > >> > > >> -----Original Message----- > > >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf > Of > > >> Dailey, Jim > > >> Sent: Tuesday, February 14, 2017 4:40 PM > > >> To: jeff.westfahl@ni.com; edk2-devel@lists.01.org > > >> Subject: Re: [edk2] [PATCH] ShellPkg/HandleParsingLib: Correct forma= t > > >> specifier for LoadedImage > > >> > > >> Jeff, > > >> > > >> Perhaps a better approach is to print *all* the LoadOptions data as = hex > > >> bytes? > > >> > > >> In addition, one might first analyze the LoadOptions data, and, when > > >> apropos, > > >> print obvious strings as strings? > > >> > > >> Regards, > > >> Jim > > >> > > >> -----Original Message----- > > >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf > Of > > Jeff > > >> Westfahl > > >> Sent: Tuesday, February 14, 2017 3:54 PM > > >> To: edk2-devel@lists.01.org > > >> Subject: [edk2] [PATCH] ShellPkg/HandleParsingLib: Correct format > > specifier > > >> for LoadedImage > > >> > > >> The format specifier for the LoadOptions field of the LoadedImage > > protocol > > >> is "%s". However, the data in LoadOptions is often generic binary da= ta. A > > >> format specifier of "%x" is more appropriate for this field. > > >> > > >> Using "dh -v" with format specifier "%s" on BIOS images based on EDK= II > > >> source before commit 891d844 can cause a crash. > > >> > > >> Contributed-under: TianoCore Contribution Agreement 1.0 > > >> Signed-off-by: Jeff Westfahl <jeff.westfahl@ni.com> > > >> --- > > >> ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni | 2 += - > > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > >> > > >> diff --git > > a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > >> b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > >> index 0d51627c5f..273a4201bc 100644 > > >> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > >> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > >> @@ -354,7 +354,7 @@ > > >> " DeviceHandle= ..: > > >> %%H%x%%N\r\n" > > >> " FilePath....= ..: > > >> %%H%x%%N\r\n" > > >> " OptionsSize.= ..: > > >> %%H%x%%N\r\n" > > >> - " LoadOptions= ...: > > >> %%H%s%%N\r\n" > > >> + " LoadOptions= ...: > > >> %%H%x%%N\r\n" > > >> " ImageBase...= ..: > > >> %%H%x%%N\r\n" > > >> " ImageSize...= ..: > > >> %%H%Lx%%N\r\n" > > >> " CodeType....= ..: > > >> %%H%s%%N\r\n" > > >> -- > > >> 2.11.0.windows.3 > > >> > > >> _______________________________________________ > > >> edk2-devel mailing list > > >> edk2-devel@lists.01.org > > >> https://lists.01.org/mailman/listinfo/edk2-devel > > >> _______________________________________________ > > >> edk2-devel mailing list > > >> edk2-devel@lists.01.org > > >> https://lists.01.org/mailman/listinfo/edk2-devel > > >> > > > _______________________________________________ > > > edk2-devel mailing list > > > edk2-devel@lists.01.org > > > https://lists.01.org/mailman/listinfo/edk2-devel > > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel