From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 996BD81F3A for ; Mon, 27 Feb 2017 08:38:43 -0800 (PST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2017 08:38:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,215,1484035200"; d="scan'208";a="230238602" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 27 Feb 2017 08:38:43 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 27 Feb 2017 08:38:43 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.47]) by FMSMSX109.amr.corp.intel.com ([169.254.15.88]) with mapi id 14.03.0248.002; Mon, 27 Feb 2017 08:38:42 -0800 From: "Carsey, Jaben" To: "Wu, Hao A" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Carsey, Jaben" Thread-Topic: [PATCH v3 10/12] ShellPkg: Refine casting expression result to bigger size Thread-Index: AQHSjyXaclRFHkvyu0i9OR/7EJI18qF9EZlg Date: Mon, 27 Feb 2017 16:38:42 +0000 Message-ID: References: <1487999555-9764-1-git-send-email-hao.a.wu@intel.com> <1487999555-9764-11-git-send-email-hao.a.wu@intel.com> In-Reply-To: <1487999555-9764-11-git-send-email-hao.a.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTE3ODAzNDQtZTkyNC00ZDlhLTljZjYtM2NlYzVkMGM1NzdmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImRNbk41cldmY3BJSzBrSjBqU0FwK1VUSDV1d2d2U3E1TGljaitNNUwxODg9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [PATCH v3 10/12] ShellPkg: Refine casting expression result to bigger size X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2017 16:38:43 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: Wu, Hao A > Sent: Friday, February 24, 2017 9:13 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Carsey, Jaben > ; Ni, Ruiyu > Subject: [PATCH v3 10/12] ShellPkg: Refine casting expression result to b= igger > size > Importance: High >=20 > There are cases that the operands of an expression are all with rank less > than UINT64/INT64 and the result of the expression is explicitly cast to > UINT64/INT64 to fit the target size. >=20 > An example will be: > UINT32 a,b; > // a and b can be any unsigned int type with rank less than UINT64, like > // UINT8, UINT16, etc. > UINT64 c; > c =3D (UINT64) (a + b); >=20 > Some static code checkers may warn that the expression result might > overflow within the rank of "int" (integer promotions) and the result is > then cast to a bigger size. >=20 > The commit refines codes by the following rules: > 1). When the expression is possible to overflow the range of unsigned int= / > int: > c =3D (UINT64)a + b; >=20 > 2). When the expression will not overflow within the rank of "int", remov= e > the explicit type casts: > c =3D a + b; >=20 > 3). When the expression will be cast to pointer of possible greater size: > UINT32 a,b; > VOID *c; > c =3D (VOID *)(UINTN)(a + b); --> c =3D (VOID *)((UINTN)a + b); >=20 > 4). When one side of a comparison expression contains only operands with > rank less than UINT32: > UINT8 a; > UINT16 b; > UINTN c; > if ((UINTN)(a + b) > c) {...} --> if (((UINT32)a + b) > c) {...} >=20 > For rule 4), if we remove the 'UINTN' type cast like: > if (a + b > c) {...} > The VS compiler will complain with warning C4018 (signed/unsigned > mismatch, level 3 warning) due to promoting 'a + b' to type 'int'. >=20 > Cc: Jaben Carsey > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Hao Wu > --- > ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/BufferImage.c > | 8 ++++---- >=20 > ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Commands > Lib.c | 4 ++-- > ShellPkg/Library/UefiShellLib/UefiShellLib.c = | 4 ++-- > 3 files changed, 8 insertions(+), 8 deletions(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/BufferImage.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/BufferImage.c > index 68d2443..1048ecd 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/BufferImage.c > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/BufferImage.c > @@ -2,7 +2,7 @@ > Defines HBufferImage - the view of the file that is visible at any poi= nt, > as well as the event handlers for editing the file >=20 > - Copyright (c) 2005 - 2014, Intel Corporation. All rights reserved. > + Copyright (c) 2005 - 2017, Intel Corporation. All rights reserved. > This program and the accompanying materials > are licensed and made available under the terms and conditions of the = BSD > License > which accompanies this distribution. The full text of the license may= be > found at > @@ -1108,15 +1108,15 @@ HBufferImageCharToHex ( > // change the character to hex > // > if (Char >=3D L'0' && Char <=3D L'9') { > - return (INTN) (Char - L'0'); > + return (Char - L'0'); > } >=20 > if (Char >=3D L'a' && Char <=3D L'f') { > - return (INTN) (Char - L'a' + 10); > + return (Char - L'a' + 10); > } >=20 > if (Char >=3D L'A' && Char <=3D L'F') { > - return (INTN) (Char - L'A' + 10); > + return (Char - L'A' + 10); > } >=20 > return -1; > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.c > index 6ebf002..a0e249e 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.c > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.c > @@ -1,7 +1,7 @@ > /** @file > Main file for NULL named library for debug1 profile shell command > functions. >=20 > - Copyright (c) 2010 - 2011, Intel Corporation. All rights reserved.
> + Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the = BSD > License > which accompanies this distribution. The full text of the license may= be > found at > @@ -193,7 +193,7 @@ HexCharToUintn ( > return Char - L'0'; > } >=20 > - return (UINTN) (10 + CharToUpper (Char) - L'A'); > + return (10 + CharToUpper (Char) - L'A'); > } >=20 > /** > diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > index 536db3c..55e8a67 100644 > --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > @@ -3,7 +3,7 @@ >=20 > (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> Copyright 2016 Dell Inc. > - Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
> + Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the = BSD > License > which accompanies this distribution. The full text of the license may= be > found at > @@ -3755,7 +3755,7 @@ InternalShellHexCharToUintn ( > return Char - L'0'; > } >=20 > - return (UINTN) (10 + InternalShellCharToUpper (Char) - L'A'); > + return (10 + InternalShellCharToUpper (Char) - L'A'); > } >=20 > /** > -- > 1.9.5.msysgit.0