public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
	"Zeng, Star" <star.zeng@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>,
	"Carsey, Jaben" <jaben.carsey@intel.com>
Subject: Re: [PATCH 2/2] ShellPkg: Link DxeSmmPerformanceLib to make DP command generic
Date: Wed, 1 Mar 2017 21:12:02 +0000	[thread overview]
Message-ID: <CB6E33457884FA40993F35157061515C54B8FB84@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5B8BBB2E@SHSMSX104.ccr.corp.intel.com>

Agree with comments.  Great way to make build easier.
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Tuesday, February 28, 2017 11:57 PM
> To: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: RE: [PATCH 2/2] ShellPkg: Link DxeSmmPerformanceLib to make DP
> command generic
> Importance: High
> 
> It's great we finally have a platform independent PerformanceLib.
> Reviewed-by: Ruiyu Ni <Ruiyu.ni@intel.com>
> 
> Thanks/Ray
> 
> > -----Original Message-----
> > From: Zeng, Star
> > Sent: Wednesday, March 1, 2017 3:53 PM
> > To: edk2-devel@lists.01.org
> > Cc: Zeng, Star <star.zeng@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>;
> > Carsey, Jaben <jaben.carsey@intel.com>; Gao, Liming
> > <liming.gao@intel.com>
> > Subject: [PATCH 2/2] ShellPkg: Link DxeSmmPerformanceLib to make DP
> > command generic
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=412
> >
> > Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> > Cc: Jaben Carsey <jaben.carsey@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Star Zeng <star.zeng@intel.com>
> > ---
> >  ShellPkg/ShellPkg.dsc | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc index
> > a87428ad6f76..4126e846cf71 100644
> > --- a/ShellPkg/ShellPkg.dsc
> > +++ b/ShellPkg/ShellPkg.dsc
> > @@ -107,7 +107,7 @@ [Components]
> >
> >    ShellPkg/Library/UefiDpLib/UefiDpLib.inf {
> >      <LibraryClasses>
> > -
> >
> PerformanceLib|MdePkg/Library/BasePerformanceLibNull/BasePerformanc
> > eLibNull.inf
> > +
> > +
> >
> PerformanceLib|MdeModulePkg/Library/DxeSmmPerformanceLib/DxeSmm
> > Perform
> > + anceLib.inf
> >        DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
> >    }
> >
> > --
> > 2.8.1.windows.1



  reply	other threads:[~2017-03-01 21:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-01  7:53 [PATCH 0/2] DP: Link DxeSmmPerformanceLib to make DP command generic Star Zeng
2017-03-01  7:53 ` [PATCH 1/2] PerformancePkg: " Star Zeng
2017-03-01  7:53 ` [PATCH 2/2] ShellPkg: " Star Zeng
2017-03-01  7:56   ` Ni, Ruiyu
2017-03-01 21:12     ` Carsey, Jaben [this message]
2017-03-01  8:20 ` [PATCH 0/2] DP: " Gao, Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CB6E33457884FA40993F35157061515C54B8FB84@FMSMSX103.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox