From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1841780331 for ; Tue, 14 Mar 2017 08:15:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1489504518; x=1521040518; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=nqHEa83Ry+yH89fmX0jyfAEdYWCSys6Ni6J3cXIJ0n4=; b=rq+E/245o60GqRkGzUeBu+i435jyEegz8RsHxHyx91q/9rejILe5SYdp 3/NWaZBY9Ijcb3/esf0glMYMqUai+Q==; Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2017 08:15:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,164,1486454400"; d="scan'208";a="67298328" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga004.jf.intel.com with ESMTP; 14 Mar 2017 08:15:18 -0700 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 14 Mar 2017 08:15:18 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.47]) by fmsmsx121.amr.corp.intel.com ([169.254.6.23]) with mapi id 14.03.0248.002; Tue, 14 Mar 2017 08:15:12 -0700 From: "Carsey, Jaben" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Carsey, Jaben" Thread-Topic: [edk2] [patch] ShellPkg/UefiShellBcfgCommandLib: Fix VS2012 build failure Thread-Index: AQHSnGPcds66QBGYbk+DYGycY+0ndKGUcrTA Date: Tue, 14 Mar 2017 15:15:09 +0000 Message-ID: References: <1489455554-94000-1-git-send-email-dandan.bi@intel.com> <1489455554-94000-2-git-send-email-dandan.bi@intel.com> In-Reply-To: <1489455554-94000-2-git-send-email-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGVjZjMxNmItYzFiOC00MmQ2LWJkYTAtZTYyYTcwZWMxYzM0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InRsWUhoWVlIUHJjYlY4R1NIY3ZqNWJsZmFpN1U0RTdMXC9tKzRtQlRFbjlrPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [patch] ShellPkg/UefiShellBcfgCommandLib: Fix VS2012 build failure X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Mar 2017 15:15:19 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Looks good to me. Reviewed-by: Jaben Carsey > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Dandan Bi > Sent: Monday, March 13, 2017 6:39 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Carsey, Jaben > Subject: [edk2] [patch] ShellPkg/UefiShellBcfgCommandLib: Fix VS2012 buil= d > failure > Importance: High >=20 > Cc: Ruiyu Ni > Cc: Jaben Carsey > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi > --- > ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c | 1 > + > 1 file changed, 1 insertion(+) >=20 > diff --git > a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c > b/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c > index 1538bc6..1122c89 100644 > --- > a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c > +++ > b/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c > @@ -400,10 +400,11 @@ BcfgMod ( > EFI_BOOT_MANAGER_LOAD_OPTION LoadOption; >=20 > ShellStatus =3D SHELL_SUCCESS; > FileList =3D NULL; > DevicePath =3D NULL; > + DevicePathBuffer =3D NULL; >=20 > ZeroMem (&LoadOption, sizeof(EFI_BOOT_MANAGER_LOAD_OPTION)); >=20 > if ( (BcfgOperation->Type =3D=3D BcfgTypeMod && BcfgOperation->Descri= ption > =3D=3D NULL) || > (BcfgOperation->Type =3D=3D BcfgTypeModf && BcfgOperation->FileNa= me > =3D=3D NULL) || > -- > 1.9.5.msysgit.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel