From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ED33280343 for ; Wed, 15 Mar 2017 13:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1489610276; x=1521146276; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=MGpHBbcei0mTOZ9wDDqyFUSfiWiJLdsawQZQZx1I0xQ=; b=rr0uB3s7pB+iPiPjflcvZxa+J9owcm3t+DElkad7FRbVSwjvu6pHkymB JCvzi+/hEhXYFVzRFAkwsq6gophNQw==; Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Mar 2017 13:37:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,170,1486454400"; d="scan'208";a="76600368" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga005.fm.intel.com with ESMTP; 15 Mar 2017 13:37:56 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 15 Mar 2017 13:37:56 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.47]) by FMSMSX152.amr.corp.intel.com ([169.254.6.239]) with mapi id 14.03.0248.002; Wed, 15 Mar 2017 13:37:56 -0700 From: "Carsey, Jaben" To: Jeff Westfahl , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Carsey, Jaben" Thread-Topic: [PATCH v2] ShellPkg/HandleParsingLib: Correct format specifier for LoadedImage Thread-Index: AQHSnQY/FiOiHG37vkWU4VbNXkMYRqGWXdzA Date: Wed, 15 Mar 2017 20:37:55 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjZmZDcwOGYtMDMwYi00MjgyLTk0N2MtMzk4ZjJkODQxOGQ3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InlwUWNtN2ZHUnBJMHlpODVSQXp4YUNWYlNYUUN1RFNtaUhWeStnYWFNXC9FPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [PATCH v2] ShellPkg/HandleParsingLib: Correct format specifier for LoadedImage X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Mar 2017 20:37:57 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Does the print call need to be updated to print this out properly? -Jaben > -----Original Message----- > From: Jeff Westfahl [mailto:jeff.westfahl@ni.com] > Sent: Tuesday, March 14, 2017 2:02 PM > To: edk2-devel@lists.01.org > Cc: Jeff Westfahl ; Ni, Ruiyu ; > Carsey, Jaben > Subject: [PATCH v2] ShellPkg/HandleParsingLib: Correct format specifier f= or > LoadedImage > Importance: High >=20 > The format specifier for the LoadOptions field of the LoadedImage protoco= l > is "%s". However, the data in LoadOptions is often generic binary data. A > format specifier of "%x" is more appropriate for this field. >=20 > Using "dh -v" with format specifier "%s" on BIOS images based on EDK II > source before commit 891d844 can cause a crash. >=20 > Cc: Ruiyu Ni > Cc: Jaben Carsey > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jeff Westfahl > --- > ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.u= ni > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > index 0d51627..273a420 100644 > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > @@ -354,7 +354,7 @@ > " DeviceHandle..: = %%H%x%%N\r\n" > " FilePath......: = %%H%x%%N\r\n" > " OptionsSize...: = %%H%x%%N\r\n" > - " LoadOptions...: = %%H%s%%N\r\n" > + " LoadOptions...: = %%H%x%%N\r\n" > " ImageBase.....: = %%H%x%%N\r\n" > " ImageSize.....: = %%H%Lx%%N\r\n" > " CodeType......: = %%H%s%%N\r\n" > -- > 2.7.4