From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2E9DE8036E for ; Wed, 22 Mar 2017 08:13:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490195623; x=1521731623; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=wXaFMn8hD1VdGPuo+Zvts3DPVnJMNBhmR0rFnZSCijE=; b=EwxCF7CWMzcgYVY7dO2+xfcZrGQgT6TS8zz1GkLAKDhtmr2mFjCv51gb mQ91PJxUlNoV+vZng0GttGNBfvOB6g==; Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2017 08:13:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,205,1486454400"; d="scan'208";a="79860497" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 22 Mar 2017 08:13:25 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.86]) by FMSMSX105.amr.corp.intel.com ([169.254.4.206]) with mapi id 14.03.0319.002; Wed, 22 Mar 2017 08:13:25 -0700 From: "Carsey, Jaben" To: Ard Biesheuvel , "edk2-devel@lists.01.org" , "leif.lindholm@linaro.org" , "lersek@redhat.com" , "Ni, Ruiyu" , "Kinney, Michael D" , "Steele, Kelly" CC: "Carsey, Jaben" Thread-Topic: [edk2] [PATCH 1/4] ShellPkg: add GUID declaration for FILE_GUID of UEFI Shell app to package Thread-Index: AQHSoxU+wOaBNjFjXEWyA9BZnfWhh6Gg9z3Q Date: Wed, 22 Mar 2017 15:13:24 +0000 Message-ID: References: <1490191448-22398-1-git-send-email-ard.biesheuvel@linaro.org> <1490191448-22398-2-git-send-email-ard.biesheuvel@linaro.org> In-Reply-To: <1490191448-22398-2-git-send-email-ard.biesheuvel@linaro.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODJmNDc4NTktM2EyZC00ZTdmLTgwMzktNTI2YWJmMTFiNmEyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkJVcldPZGx2a2xmRUJvSDZEUDEyWUdZU1oxZUFMSkZWMlNQQ1l6b2NDVmc9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [PATCH 1/4] ShellPkg: add GUID declaration for FILE_GUID of UEFI Shell app to package X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 15:13:43 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ard, I am good with this change. =20 What do you think about a comment to the INF file so that if someone makes = a change to the GUI there, they are informed that they need to change this = location? I worry as usually updating an INF GUID is permitted without any= need to change another file... -Jaben > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Ard Biesheuvel > Sent: Wednesday, March 22, 2017 7:04 AM > To: edk2-devel@lists.01.org; leif.lindholm@linaro.org; lersek@redhat.com; > Carsey, Jaben ; Ni, Ruiyu ; > Kinney, Michael D ; Steele, Kelly > > Cc: Ard Biesheuvel > Subject: [edk2] [PATCH 1/4] ShellPkg: add GUID declaration for FILE_GUID = of > UEFI Shell app to package > Importance: High >=20 > In > QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager. > c, > there is a definition of mUefiShellFileGuid which is a constant reference > to the FILE_GUID as defined in ShellPkg/Application/Shell/Shell.inf. >=20 > To prevent the need for duplicating it to other modules, promote it to > a proper global GUID, and add it to the ShellPkg.dec package declaration. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > ShellPkg/ShellPkg.dec | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/ShellPkg/ShellPkg.dec b/ShellPkg/ShellPkg.dec > index bb31c2df8cb3..3ad17a44b447 100644 > --- a/ShellPkg/ShellPkg.dec > +++ b/ShellPkg/ShellPkg.dec > @@ -57,6 +57,9 @@ [Guids] > gShellTftpHiiGuid =3D {0x738a9314, 0x82c1, 0x4592, {0x8f= , 0xf7, 0xc1, > 0xbd, 0xf1, 0xb2, 0x0e, 0xd4}} > gShellBcfgHiiGuid =3D {0x5f5f605d, 0x1583, 0x4a2d, {0xa6= , 0xb2, 0xeb, > 0x12, 0xda, 0xb4, 0xa2, 0xb6}} >=20 > + # FILE_GUID as defined in ShellPkg/Application/Shell/Shell.inf > + gUefiShellFileGuid =3D {0x7c04a583, 0x9e3e, 0x4f1c, {0xad= , 0x65, 0xe0, > 0x52, 0x68, 0xd0, 0xb4, 0xd1}} > + > [Protocols] > gEfiShellEnvironment2Guid =3D {0x47c7b221, 0xc42a, 0x11d2, {= 0x8e, > 0x57, 0x00, 0xa0, 0xc9, 0x69, 0x72, 0x3b}} > gEfiShellInterfaceGuid =3D {0x47c7b223, 0xc42a, 0x11d2, {= 0x8e, 0x57, > 0x00, 0xa0, 0xc9, 0x69, 0x72, 0x3b}} > -- > 2.7.4 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel