From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 100C1803DF for ; Wed, 22 Mar 2017 08:18:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490195923; x=1521731923; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=8LPEaQuUdbKZESmEt6p+lki8zOgtvjEkEGjKwyt4KrQ=; b=b1CL62QVb1Ce/NvKupd37YzdVfqiKkbwBoe3zZHGvqSTsZgP1IF6Z9iy PijJ7ryaNQQXHTIYCgwrNUMfNc1VAg==; Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2017 08:18:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,205,1486454400"; d="scan'208";a="1145638927" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 22 Mar 2017 08:18:34 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 22 Mar 2017 08:18:34 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.86]) by FMSMSX153.amr.corp.intel.com ([169.254.9.181]) with mapi id 14.03.0319.002; Wed, 22 Mar 2017 08:18:34 -0700 From: "Carsey, Jaben" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" CC: "Chen, Chen A" , "Carsey, Jaben" Thread-Topic: [PATCH] ShellPkg: Add Shell invocation option '-exit' Thread-Index: AQHSouOUTjJxjr4nXU+ohnzmESe8U6Gg+SGA Date: Wed, 22 Mar 2017 15:18:33 +0000 Message-ID: References: <20170322080856.681884-1-ruiyu.ni@intel.com> In-Reply-To: <20170322080856.681884-1-ruiyu.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMThmZDMxMzgtMzNiZS00NzdhLTg3ZGUtMmMwZDlkZjU1YTdkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkZxMVZYazJlTWF3emQ1Q1FXdnpDZ0ZsOWc5RkFYbzV3Q0JId3R4Snk3NGc9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg: Add Shell invocation option '-exit' X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 15:18:43 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I think we also need to modify one other location (I did a search for -_exi= t and didn't see any more): \shellpkg\Application\Shell\ShellProtocol.c Line 1784: StrnCatGrow(&Temp, &Size, L"Shell.efi -_exit ", 0); > -----Original Message----- > From: Ni, Ruiyu > Sent: Wednesday, March 22, 2017 1:09 AM > To: edk2-devel@lists.01.org > Cc: Chen, Chen A ; Carsey, Jaben > > Subject: [PATCH] ShellPkg: Add Shell invocation option '-exit' > Importance: High >=20 > From: Chen A Chen >=20 > According to Shell spec 2.2 '-exit' invocation option is used to specify > that after running the command line when launched, the UEFI Shell must > immediately exit. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Chen A Chen > Cc: Jaben Carsey > --- > ShellPkg/Application/Shell/Shell.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/ShellPkg/Application/Shell/Shell.c > b/ShellPkg/Application/Shell/Shell.c > index 350d7ff..dfcbfb8 100644 > --- a/ShellPkg/Application/Shell/Shell.c > +++ b/ShellPkg/Application/Shell/Shell.c > @@ -1022,7 +1022,7 @@ ProcessCommandLine( > } > } else if (UnicodeCollation->StriColl ( > UnicodeCollation, > - L"-_exit", > + L"-exit", > CurrentArg > ) =3D=3D 0) { > ShellInfoObject.ShellInitSettings.BitUnion.Bits.Exit =3D T= RUE; > -- > 2.9.0.windows.1