Re: [PATCH 1/4] ShellPkg: add GUID declaration for FILE_GUID of UEFI Shell app to package

["Carsey, Jaben" <jaben.carsey@intel.com>]

That would be quite nice.  I know that spinning GUIDs due to a non-backwards compatible change can be a scary thing.

-Jaben

> -----Original Message-----
> From: Kinney, Michael D
> Sent: Wednesday, March 22, 2017 8:40 AM
> To: Carsey, Jaben <jaben.carsey@intel.com>; Ard Biesheuvel
> <ard.biesheuvel@linaro.org>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-devel@lists.01.org;
> leif.lindholm@linaro.org; lersek@redhat.com
> Subject: RE: [edk2] [PATCH 1/4] ShellPkg: add GUID declaration for
> FILE_GUID of UEFI Shell app to package
> Importance: High
> 
> Jaben,
> 
> I like the added comment.
> 
> Maybe we should consider an INF spec enhancement to support a GUID C
> Name
> for the FILE_GUID define, and the GUID C Names can be any GUID declared
> in a dependent packages from the [Packages] section of the INF.  This
> would eliminate the GUID value duplication for this use case.
> 
> Mike
> 
> > -----Original Message-----
> > From: Carsey, Jaben
> > Sent: Wednesday, March 22, 2017 8:21 AM
> > To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-devel@lists.01.org;
> leif.lindholm@linaro.org;
> > Kinney, Michael D <michael.d.kinney@intel.com>; lersek@redhat.com;
> Carsey, Jaben
> > <jaben.carsey@intel.com>
> > Subject: RE: [edk2] [PATCH 1/4] ShellPkg: add GUID declaration for
> FILE_GUID of UEFI
> > Shell app to package
> >
> > Yes. that looks great.
> >
> > For the changes to ShellPkg.
> > Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> >
> > > -----Original Message-----
> > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > > Ard Biesheuvel
> > > Sent: Wednesday, March 22, 2017 8:20 AM
> > > To: Carsey, Jaben <jaben.carsey@intel.com>
> > > Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-devel@lists.01.org;
> > > leif.lindholm@linaro.org; Kinney, Michael D
> <michael.d.kinney@intel.com>;
> > > lersek@redhat.com
> > > Subject: Re: [edk2] [PATCH 1/4] ShellPkg: add GUID declaration for
> > > FILE_GUID of UEFI Shell app to package
> > > Importance: High
> > >
> > > On 22 March 2017 at 15:13, Carsey, Jaben <jaben.carsey@intel.com>
> wrote:
> > > > Ard,
> > > >
> > > > I am good with this change.
> > > >
> > > > What do you think about a comment to the INF file so that if someone
> > > makes a change to the GUI there, they are informed that they need to
> > > change this location?  I worry as usually updating an INF GUID is
> permitted
> > > without any need to change another file...
> > > >
> > >
> > > Something like this perhaps?
> > >
> > > --- a/ShellPkg/Application/Shell/Shell.inf
> > > +++ b/ShellPkg/Application/Shell/Shell.inf
> > > @@ -17,7 +17,7 @@
> > >  [Defines]
> > >    INF_VERSION    = 0x00010006
> > >    BASE_NAME      = Shell
> > > -  FILE_GUID      = 7C04A583-9E3E-4f1c-AD65-E05268D0B4D1
> > > +  FILE_GUID      = 7C04A583-9E3E-4f1c-AD65-E05268D0B4D1 #
> > > gUefiShellFileGuid
> > >    MODULE_TYPE    = UEFI_APPLICATION
> > >    VERSION_STRING = 1.0
> > >    ENTRY_POINT    = UefiMain
> > >
> > > (Note that the same FILE_GUID occurs in ShellBinPkg as well, but
> > > people are unlikely that randomly change that one without regard to
> > > the source build)
> > > _______________________________________________
> > > edk2-devel mailing list
> > > edk2-devel@lists.01.org
> > > https://lists.01.org/mailman/listinfo/edk2-devel