From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4EF3A80294 for ; Wed, 22 Mar 2017 08:41:03 -0700 (PDT) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP; 22 Mar 2017 08:41:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,205,1486454400"; d="scan'208";a="79447982" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 22 Mar 2017 08:41:02 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 22 Mar 2017 08:41:02 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.86]) by fmsmsx101.amr.corp.intel.com ([169.254.1.70]) with mapi id 14.03.0319.002; Wed, 22 Mar 2017 08:41:02 -0700 From: "Carsey, Jaben" To: "Kinney, Michael D" , Ard Biesheuvel CC: "Ni, Ruiyu" , "edk2-devel@lists.01.org" , "leif.lindholm@linaro.org" , "lersek@redhat.com" , "Carsey, Jaben" Thread-Topic: [edk2] [PATCH 1/4] ShellPkg: add GUID declaration for FILE_GUID of UEFI Shell app to package Thread-Index: AQHSoxU+wOaBNjFjXEWyA9BZnfWhh6Gg9z3QgAB3eQD//4rb8IAAepyA//+K1/A= Date: Wed, 22 Mar 2017 15:41:02 +0000 Message-ID: References: <1490191448-22398-1-git-send-email-ard.biesheuvel@linaro.org> <1490191448-22398-2-git-send-email-ard.biesheuvel@linaro.org> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDhjM2VlYTctZTM0OC00YTIyLWJkZjctZTk5N2VlZDEzZGZiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Im9TTnBRWTcxU1MzM1wvcEtEeFlQU0JUd294c1E1NFd5XC8xdXRhWjdjU2ExZz0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [PATCH 1/4] ShellPkg: add GUID declaration for FILE_GUID of UEFI Shell app to package X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 15:41:03 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable That would be quite nice. I know that spinning GUIDs due to a non-backward= s compatible change can be a scary thing. -Jaben > -----Original Message----- > From: Kinney, Michael D > Sent: Wednesday, March 22, 2017 8:40 AM > To: Carsey, Jaben ; Ard Biesheuvel > ; Kinney, Michael D > > Cc: Ni, Ruiyu ; edk2-devel@lists.01.org; > leif.lindholm@linaro.org; lersek@redhat.com > Subject: RE: [edk2] [PATCH 1/4] ShellPkg: add GUID declaration for > FILE_GUID of UEFI Shell app to package > Importance: High >=20 > Jaben, >=20 > I like the added comment. >=20 > Maybe we should consider an INF spec enhancement to support a GUID C > Name > for the FILE_GUID define, and the GUID C Names can be any GUID declared > in a dependent packages from the [Packages] section of the INF. This > would eliminate the GUID value duplication for this use case. >=20 > Mike >=20 > > -----Original Message----- > > From: Carsey, Jaben > > Sent: Wednesday, March 22, 2017 8:21 AM > > To: Ard Biesheuvel > > Cc: Ni, Ruiyu ; edk2-devel@lists.01.org; > leif.lindholm@linaro.org; > > Kinney, Michael D ; lersek@redhat.com; > Carsey, Jaben > > > > Subject: RE: [edk2] [PATCH 1/4] ShellPkg: add GUID declaration for > FILE_GUID of UEFI > > Shell app to package > > > > Yes. that looks great. > > > > For the changes to ShellPkg. > > Reviewed-by: Jaben Carsey > > > > > -----Original Message----- > > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf O= f > > > Ard Biesheuvel > > > Sent: Wednesday, March 22, 2017 8:20 AM > > > To: Carsey, Jaben > > > Cc: Ni, Ruiyu ; edk2-devel@lists.01.org; > > > leif.lindholm@linaro.org; Kinney, Michael D > ; > > > lersek@redhat.com > > > Subject: Re: [edk2] [PATCH 1/4] ShellPkg: add GUID declaration for > > > FILE_GUID of UEFI Shell app to package > > > Importance: High > > > > > > On 22 March 2017 at 15:13, Carsey, Jaben > wrote: > > > > Ard, > > > > > > > > I am good with this change. > > > > > > > > What do you think about a comment to the INF file so that if someon= e > > > makes a change to the GUI there, they are informed that they need to > > > change this location? I worry as usually updating an INF GUID is > permitted > > > without any need to change another file... > > > > > > > > > > Something like this perhaps? > > > > > > --- a/ShellPkg/Application/Shell/Shell.inf > > > +++ b/ShellPkg/Application/Shell/Shell.inf > > > @@ -17,7 +17,7 @@ > > > [Defines] > > > INF_VERSION =3D 0x00010006 > > > BASE_NAME =3D Shell > > > - FILE_GUID =3D 7C04A583-9E3E-4f1c-AD65-E05268D0B4D1 > > > + FILE_GUID =3D 7C04A583-9E3E-4f1c-AD65-E05268D0B4D1 # > > > gUefiShellFileGuid > > > MODULE_TYPE =3D UEFI_APPLICATION > > > VERSION_STRING =3D 1.0 > > > ENTRY_POINT =3D UefiMain > > > > > > (Note that the same FILE_GUID occurs in ShellBinPkg as well, but > > > people are unlikely that randomly change that one without regard to > > > the source build) > > > _______________________________________________ > > > edk2-devel mailing list > > > edk2-devel@lists.01.org > > > https://lists.01.org/mailman/listinfo/edk2-devel