From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2744F80294 for ; Wed, 22 Mar 2017 08:43:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490197387; x=1521733387; h=from:to:cc:subject:date:message-id:references: content-transfer-encoding:mime-version; bh=6QiGL0O8TZKA6tkcmzPEa61uTVySvvp38xuJPFtVKIM=; b=a5w7QtwaoOsRs7Lyplf8nC8HqS9RbCTfRHRLTR0jUEu9BK+HAq4oouJF TDPjbkWkTIdXVt3WFBb+ZWFWw2rxvw==; Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2017 08:43:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,205,1486454400"; d="scan'208";a="1125823626" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 22 Mar 2017 08:43:06 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 22 Mar 2017 08:43:06 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.86]) by fmsmsx124.amr.corp.intel.com ([169.254.8.226]) with mapi id 14.03.0319.002; Wed, 22 Mar 2017 08:43:06 -0700 From: "Carsey, Jaben" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" CC: "Chen, Chen A" , "Ard Biesheuvel (ard.biesheuvel@linaro.org)" , "Carsey, Jaben" Thread-Topic: [PATCH] ShellPkg: Add Shell invocation option '-exit' Thread-Index: AQHSouOUTjJxjr4nXU+ohnzmESe8U6Gg+SGAgAAGk1A= Date: Wed, 22 Mar 2017 15:43:05 +0000 Message-ID: References: <20170322080856.681884-1-ruiyu.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMThmZDMxMzgtMzNiZS00NzdhLTg3ZGUtMmMwZDlkZjU1YTdkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkZxMVZYazJlTWF3emQ1Q1FXdnpDZ0ZsOWc5RkFYbzV3Q0JId3R4Snk3NGc9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg: Add Shell invocation option '-exit' X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 15:43:07 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable So based on the other discussion about the Shell GUID and a bit of thinking= , I realized this is non backwards compatible. We should spin GUID for She= ll (and ShellBin compiled versions when compiled next)... I guess we get to do a real test of the removal of hard coded shell GUIDs i= n Ard's most recent patch series. -Jaben > -----Original Message----- > From: Carsey, Jaben > Sent: Wednesday, March 22, 2017 8:19 AM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Chen, Chen A ; Carsey, Jaben > > Subject: RE: [PATCH] ShellPkg: Add Shell invocation option '-exit' >=20 > I think we also need to modify one other location (I did a search for -_e= xit > and didn't see any more): >=20 > \shellpkg\Application\Shell\ShellProtocol.c > Line 1784: StrnCatGrow(&Temp, &Size, L"Shell.efi -_exit ", 0); >=20 > > -----Original Message----- > > From: Ni, Ruiyu > > Sent: Wednesday, March 22, 2017 1:09 AM > > To: edk2-devel@lists.01.org > > Cc: Chen, Chen A ; Carsey, Jaben > > > > Subject: [PATCH] ShellPkg: Add Shell invocation option '-exit' > > Importance: High > > > > From: Chen A Chen > > > > According to Shell spec 2.2 '-exit' invocation option is used to specif= y > > that after running the command line when launched, the UEFI Shell must > > immediately exit. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Chen A Chen > > Cc: Jaben Carsey > > --- > > ShellPkg/Application/Shell/Shell.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/ShellPkg/Application/Shell/Shell.c > > b/ShellPkg/Application/Shell/Shell.c > > index 350d7ff..dfcbfb8 100644 > > --- a/ShellPkg/Application/Shell/Shell.c > > +++ b/ShellPkg/Application/Shell/Shell.c > > @@ -1022,7 +1022,7 @@ ProcessCommandLine( > > } > > } else if (UnicodeCollation->StriColl ( > > UnicodeCollation, > > - L"-_exit", > > + L"-exit", > > CurrentArg > > ) =3D=3D 0) { > > ShellInfoObject.ShellInitSettings.BitUnion.Bits.Exit =3D= TRUE; > > -- > > 2.9.0.windows.1