Re: [PATCH] ShellPkg/comp: Fix file tag name.

["Carsey, Jaben" <jaben.carsey@intel.com>]

Do we need to localize that in HII? I am unsure, but I  don't have strong opinion.

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Wednesday, April 19, 2017 7:51 PM
> To: edk2-devel@lists.01.org
> Cc: Chen, Chen A <chen.a.chen@intel.com>
> Subject: [edk2] [PATCH] ShellPkg/comp: Fix file tag name.
> Importance: High
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Chen A Chen <chen.a.chen@intel.com>
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> ---
>  ShellPkg/Library/UefiShellDebug1CommandsLib/Comp.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Comp.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/Comp.c
> index 05edcb7c99..f45f663dbb 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Comp.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Comp.c
> @@ -30,7 +30,8 @@ typedef enum {
>  /**
>    Function to print differnt point data.
> 
> -  @param[in]  FileName        File name
> +  @param[in]  FileName        File name.
> +  @param[in]  FileTag         File tag name.
>    @param[in]  Buffer          Data buffer to be printed.
>    @param[in]  BufferSize      Size of the data to be printed.
>    @param[in]  Address         Address of the differnt point.
> @@ -40,6 +41,7 @@ typedef enum {
>  VOID
>  PrintDifferentPoint(
>    CONST CHAR16  *FileName,
> +  CHAR16        *FileTag,
>    UINT8         *Buffer,
>    UINT64        BufferSize,
>    UINTN         Address,
> @@ -48,7 +50,7 @@ PrintDifferentPoint(
>  {
>    UINTN Index;
> 
> -  ShellPrintEx (-1, -1, L"%s: %s\r\n  %08x:", L"File1", FileName, Address);
> +  ShellPrintEx (-1, -1, L"%s: %s\r\n  %08x:", FileTag, FileName, Address);
> 
>    //
>    // Print data in hex-format.
> @@ -302,8 +304,8 @@ ShellCommandRunComp (
>               ) {
> 
>              ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN
> (STR_COMP_DIFFERENCE_POINT), gShellDebug1HiiHandle,
> ++DiffPointNumber);
> -            PrintDifferentPoint (FileName1, DataFromFile1, InsertPosition1,
> DiffPointAddress, DifferentBytes);
> -            PrintDifferentPoint (FileName2, DataFromFile2, InsertPosition2,
> DiffPointAddress, DifferentBytes);
> +            PrintDifferentPoint (FileName1, L"File1", DataFromFile1,
> InsertPosition1, DiffPointAddress, DifferentBytes);
> +            PrintDifferentPoint (FileName2, L"File2", DataFromFile2,
> InsertPosition2, DiffPointAddress, DifferentBytes);
> 
>              //
>              // One of two buffuers is empty, it means this is the last different
> point.
> --
> 2.12.2.windows.2
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel