From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5625A21954068 for ; Thu, 20 Apr 2017 13:20:40 -0700 (PDT) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Apr 2017 13:20:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,227,1488873600"; d="scan'208";a="76910428" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 20 Apr 2017 13:20:38 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 20 Apr 2017 13:20:38 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.246]) by FMSMSX109.amr.corp.intel.com ([169.254.15.83]) with mapi id 14.03.0319.002; Thu, 20 Apr 2017 13:20:38 -0700 From: "Carsey, Jaben" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" CC: "Chen, Chen A" Thread-Topic: [edk2] [PATCH] ShellPkg/comp: Fix file tag name. Thread-Index: AQHSuYDx0WT6OJl+902QwKVc1pUmP6HOs9kg Date: Thu, 20 Apr 2017 20:20:38 +0000 Message-ID: References: <20170420025043.66620-1-ruiyu.ni@intel.com> In-Reply-To: <20170420025043.66620-1-ruiyu.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzc2NGVkZjktN2Q2NC00Nzg0LTlhY2QtNzM5MmYzZWU3M2JkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImM5bEF5UVNIWExhZjdVTzJveWgyMlE2cHRGaUVoOGNFWUUrSFlpSVdtRmM9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg/comp: Fix file tag name. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Apr 2017 20:20:40 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Do we need to localize that in HII? I am unsure, but I don't have strong o= pinion. Reviewed-by: Jaben Carsey > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Wednesday, April 19, 2017 7:51 PM > To: edk2-devel@lists.01.org > Cc: Chen, Chen A > Subject: [edk2] [PATCH] ShellPkg/comp: Fix file tag name. > Importance: High >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Chen A Chen > Reviewed-by: Ruiyu Ni > --- > ShellPkg/Library/UefiShellDebug1CommandsLib/Comp.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) >=20 > diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Comp.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/Comp.c > index 05edcb7c99..f45f663dbb 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Comp.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Comp.c > @@ -30,7 +30,8 @@ typedef enum { > /** > Function to print differnt point data. >=20 > - @param[in] FileName File name > + @param[in] FileName File name. > + @param[in] FileTag File tag name. > @param[in] Buffer Data buffer to be printed. > @param[in] BufferSize Size of the data to be printed. > @param[in] Address Address of the differnt point. > @@ -40,6 +41,7 @@ typedef enum { > VOID > PrintDifferentPoint( > CONST CHAR16 *FileName, > + CHAR16 *FileTag, > UINT8 *Buffer, > UINT64 BufferSize, > UINTN Address, > @@ -48,7 +50,7 @@ PrintDifferentPoint( > { > UINTN Index; >=20 > - ShellPrintEx (-1, -1, L"%s: %s\r\n %08x:", L"File1", FileName, Addres= s); > + ShellPrintEx (-1, -1, L"%s: %s\r\n %08x:", FileTag, FileName, Address= ); >=20 > // > // Print data in hex-format. > @@ -302,8 +304,8 @@ ShellCommandRunComp ( > ) { >=20 > ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN > (STR_COMP_DIFFERENCE_POINT), gShellDebug1HiiHandle, > ++DiffPointNumber); > - PrintDifferentPoint (FileName1, DataFromFile1, InsertPositio= n1, > DiffPointAddress, DifferentBytes); > - PrintDifferentPoint (FileName2, DataFromFile2, InsertPositio= n2, > DiffPointAddress, DifferentBytes); > + PrintDifferentPoint (FileName1, L"File1", DataFromFile1, > InsertPosition1, DiffPointAddress, DifferentBytes); > + PrintDifferentPoint (FileName2, L"File2", DataFromFile2, > InsertPosition2, DiffPointAddress, DifferentBytes); >=20 > // > // One of two buffuers is empty, it means this is the last d= ifferent > point. > -- > 2.12.2.windows.2 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel