From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 713A0219493F2 for ; Wed, 26 Apr 2017 11:00:04 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2017 11:00:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,255,1488873600"; d="scan'208";a="81128682" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 26 Apr 2017 11:00:03 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.246]) by fmsmsx107.amr.corp.intel.com ([169.254.6.232]) with mapi id 14.03.0319.002; Wed, 26 Apr 2017 11:00:02 -0700 From: "Carsey, Jaben" To: Jeff Westfahl , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" Thread-Topic: [edk2][PATCH] ShellPkg/ShellCommandLib: Update DumpHex to print {|}~ Thread-Index: AQHSvrQ80HroUdWfVEGX59+G0ZR6gaHX8BAg Date: Wed, 26 Apr 2017 18:00:02 +0000 Message-ID: References: <1493228430-15322-1-git-send-email-jeff.westfahl@ni.com> In-Reply-To: <1493228430-15322-1-git-send-email-jeff.westfahl@ni.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmY1ZDRkZDktZjZhNS00NzJhLTkzNjktNzA0NzE0MzgzY2M2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlZkcFlQSW1cL1lWXC9hYWJQQWhiU1BrcDdpTXdjTVhCZnJpYjlnXC8rR2o2S3M9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg/ShellCommandLib: Update DumpHex to print {|}~ X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Apr 2017 18:00:04 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I think that this is a correct change, but I do not understand the problem = this solves. =20 -Jaben > -----Original Message----- > From: Jeff Westfahl [mailto:jeff.westfahl@ni.com] > Sent: Wednesday, April 26, 2017 10:41 AM > To: edk2-devel@lists.01.org > Cc: Jeff Westfahl ; Ni, Ruiyu ; > Carsey, Jaben > Subject: [edk2][PATCH] ShellPkg/ShellCommandLib: Update DumpHex to > print {|}~ > Importance: High >=20 > ASCII characters {|}~ should be printed by DumpHex. >=20 > Cc: Ruiyu Ni > Cc: Jaben Carsey > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jeff Westfahl > --- > ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c > b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c > index a2ebc8f..bd14878 100644 > --- a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c > +++ b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c > @@ -1745,7 +1745,7 @@ DumpHex ( > Val[Index * 3 + 0] =3D Hex[TempByte >> 4]; > Val[Index * 3 + 1] =3D Hex[TempByte & 0xF]; > Val[Index * 3 + 2] =3D (CHAR8) ((Index =3D=3D 7) ? '-' : ' '); > - Str[Index] =3D (CHAR8) ((TempByte < ' ' || TempByte > 'z'= ) ? '.' : > TempByte); > + Str[Index] =3D (CHAR8) ((TempByte < ' ' || TempByte > '~'= ) ? '.' : > TempByte); > } >=20 > Val[Index * 3] =3D 0; > -- > 2.7.4