From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AEA9021A13487 for ; Thu, 4 May 2017 09:31:41 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 May 2017 09:31:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,287,1491289200"; d="scan'208";a="83671632" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 04 May 2017 09:31:41 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 4 May 2017 09:31:41 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.238]) by fmsmsx123.amr.corp.intel.com ([169.254.7.244]) with mapi id 14.03.0319.002; Thu, 4 May 2017 09:31:41 -0700 From: "Carsey, Jaben" To: Jeff Westfahl CC: "Ni, Ruiyu" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] ShellPkg: Difference in behavior of 'dh' between old shell and new Thread-Index: AQHSuTN4oDVBGvLT70ic3rGp6F7BbaHM9roAgBfaUoD//6PrMA== Date: Thu, 4 May 2017 16:31:40 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmFlZGQ5YTYtZWUxNC00NmI3LTk0NmYtNmM2OTY5ZTU4NDNmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlRwK0o1bUxQTHFLVm9jNTZlbXByTzMrXC9vdDNLa0c4TUtzNXdYM0FxWkZrPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: ShellPkg: Difference in behavior of 'dh' between old shell and new X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 May 2017 16:31:41 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pretty much.=20 The shell can absolutely perform better by using them, but it must not gene= rate errors due to not finding them. > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Jeff Westfahl > Sent: Thursday, May 04, 2017 8:00 AM > To: Carsey, Jaben > Cc: Ni, Ruiyu ; edk2-devel@lists.01.org > Subject: Re: [edk2] ShellPkg: Difference in behavior of 'dh' between old = shell > and new > Importance: High >=20 > Hi Jaben, >=20 > No PI protocols can be required means that I can try to use them? And > gracefully handle the case where they aren't found? >=20 > Regards, > Jeff >=20 > On Wed, 19 Apr 2017, Carsey, Jaben wrote: >=20 > > That would be welcome; I don't know how it was missed. A caveat is tha= t > the shell should use UEFI protocols only. No PI protocols can be require= d > (optional is ok). > > > > Only the specific output controlled by "-sfo" is severely constrained b= y the > spec. > > > >> -----Original Message----- > >> From: Jeff Westfahl [mailto:jeff.westfahl@ni.com] > >> Sent: Wednesday, April 19, 2017 10:36 AM > >> To: edk2-devel@lists.01.org > >> Cc: Carsey, Jaben ; Ni, Ruiyu > > >> Subject: [edk2] ShellPkg: Difference in behavior of 'dh' between old s= hell > and > >> new > >> Importance: High > >> > >> I noticed a difference in behavior of 'dh' between the old shell and t= he > new shell. > >> With the old shell, 'dh -v' for a LoadedImage handle shows the > >> following: > >> > >> Handle D3 (3A537F98) > >> Image (3A532818) File:MicrocodeUpdate > >> ParentHandle..: 3A64F118 > >> SystemTable...: 3D2A8F18 > >> DeviceHandle..: 3B1B2098 > >> FilePath......: FvFile(F3331DE6-4A55-44E4-B767-7453F7A1A021) > >> ImageBase.....: 3D650000 - 3D655540 > >> ImageSize.....: 5540 > >> CodeType......: RT_code > >> DataType......: RT_data > >> > >> With the new shell, I get this for the same LoadedImage handle: > >> > >> D3: 3A537F98 > >> LoadedImage > >> Revision......: 0x00001000 > >> ParentHandle..: 3A64F118 > >> SystemTable...: 3D2A8F18 > >> DeviceHandle..: 3B1B2098 > >> FilePath......: 3A539018 > >> OptionsSize...: 0 > >> LoadOptions...: 0 > >> ImageBase.....: 3D650000 > >> ImageSize.....: 5540 > >> CodeType......: EfiRuntimeServicesCode > >> DataType......: EfiRuntimeServicesData > >> Unload........: 0 > >> > >> The old shell shows the name of the file associated with the > LoadedImage, > >> which seems like useful information. Is this omission intentional or a= n > oversight? > >> Would a patch adding the file name to ShellPkg be welcomed? > >> > >> Regards, > >> Jeff > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel