From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 28E6A21AF0335 for ; Sun, 14 May 2017 15:13:34 -0700 (PDT) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 May 2017 15:13:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,341,1491289200"; d="scan'208";a="86689209" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 14 May 2017 15:13:33 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.204]) by fmsmsx107.amr.corp.intel.com ([169.254.6.232]) with mapi id 14.03.0319.002; Sun, 14 May 2017 15:13:33 -0700 From: "Carsey, Jaben" To: Jeff Westfahl , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" Thread-Topic: [edk2] [PATCH] ShellPkg/UefiShellLib: Check correct variable for NULL Thread-Index: AQHSy2Axw+4jKaSvs0egDMjal+EDF6H0Z+Ng Date: Sun, 14 May 2017 22:13:33 +0000 Message-ID: References: <1494621700-13558-1-git-send-email-jeff.westfahl@ni.com> In-Reply-To: <1494621700-13558-1-git-send-email-jeff.westfahl@ni.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg/UefiShellLib: Check correct variable for NULL X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 May 2017 22:13:34 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Je= ff > Westfahl > Sent: Friday, May 12, 2017 1:42 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Carsey, Jaben > Subject: [edk2] [PATCH] ShellPkg/UefiShellLib: Check correct variable for= NULL > Importance: High >=20 > Cc: Ruiyu Ni > Cc: Jaben Carsey > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jeff Westfahl > --- > ShellPkg/Library/UefiShellLib/UefiShellLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > index 55e8a67..0f37886 100644 > --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > @@ -702,7 +702,7 @@ ShellOpenFileByName( > // Create the directory to create the file in > // > FileNameCopy =3D AllocateCopyPool (StrSize (FileName), FileName); > - if (FileName =3D=3D NULL) { > + if (FileNameCopy =3D=3D NULL) { > return (EFI_OUT_OF_RESOURCES); > } > PathCleanUpDirectories (FileNameCopy); > -- > 2.7.4 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel