public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: GN Keshava <keshava.gn@gmail.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: Issue in ConvertHandleIndexToHandle and ConvertHandleToHandleIndex
Date: Tue, 6 Jun 2017 21:06:43 +0000	[thread overview]
Message-ID: <CB6E33457884FA40993F35157061515C6CAA8EC1@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <CABKwMdtif1ox=1h+XHN8hA1Js95BartFHrr8evjFfdYRqiQqCA@mail.gmail.com>

The problem is how the library assigns “handle indexes”… it just keeps a list of the ones it has given out and only supports those.

Your application is linked to the library and is keeping it’s own version of this list.  So when you request a handle index, it gives you one… but your version of the list has nothing to do with the shell’s version.

Sadly, the UEFI Shell spec doesn’t assume that shell applications will want access to the handle index concept that I can think of.

I think that your current solution is the best one.

-Jaben

From: GN Keshava [mailto:keshava.gn@gmail.com]
Sent: Tuesday, June 06, 2017 9:32 AM
To: Carsey, Jaben <jaben.carsey@intel.com>; edk2-devel@lists.01.org
Subject: Re: [edk2] Issue in ConvertHandleIndexToHandle and ConvertHandleToHandleIndex
Importance: High


Thanks Jaben.

I expected this answer. :) Definitely I can't do that as of now.

But do you think this would cause mismatch between the handle index that i get in my application? The handle index I'm getting is differing, even if the handle value is same.

And, could you suggest any other ways to fix this, other than embedding my app into the shell?

Or do you suggest my temporary workaround , in which I'm embedding my own sermode functionality inside my application ? The functionality​ is working and I'm able to use com port. But it's annoying to have different information in app than a shell command! :(

Thanks again.
Regards,
Keshava

On Tue, Jun 6, 2017, 9:45 PM Carsey, Jaben <jaben.carsey@intel.com<mailto:jaben.carsey@intel.com>> wrote:
In general, you should really try to avoid it.  it means you have to build and distribute a complete shell instead of a single application.  There are some shell commands that simply cannot function without information not available via the shell protocol.  If you find you need information, then maybe we should consider that missing information to be added to the shell protocol.

-Jaben

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org<mailto:edk2-devel-bounces@lists.01.org>] On Behalf Of
> GN Keshava
> Sent: Tuesday, June 06, 2017 9:12 AM
> To: Carsey, Jaben <jaben.carsey@intel.com<mailto:jaben.carsey@intel.com>>; edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
> Subject: Re: [edk2] Issue in ConvertHandleIndexToHandle and
> ConvertHandleToHandleIndex
> Importance: High
>
> Hi Jaben,
>
> Thanks for the reply.
>
>
> I understand that the sermode command is in shell, and it's sharing
> information through libraries.
>
>
> Can you tell me more about the library requirement of module to be linked
> into shell? How i can do this?
>
>
> Thanks again.
>
> Regards,
>
> Keshava
>
> On Tue, Jun 6, 2017, 9:15 PM Carsey, Jaben <jaben.carsey@intel.com<mailto:jaben.carsey@intel.com>>
> wrote:
>
> > That library may require the module to be linked into the shell.  Remember
> > that the sermode command is actually in the same binary as the shell and
> > the shell and the command are sharing information through libraries.
> >
> > > -----Original Message-----
> > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org<mailto:edk2-devel-bounces@lists.01.org>] On Behalf Of
> > > GN Keshava
> > > Sent: Tuesday, June 06, 2017 3:20 AM
> > > To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
> > > Subject: [edk2] Issue in ConvertHandleIndexToHandle and
> > > ConvertHandleToHandleIndex
> > > Importance: High
> > >
> > > Hi,
> > >
> > > Thanks all for your kind help.
> > >
> > > I'm doing few operations using serial port. So, I've done a small serial
> > > driver by referring FTDI code, and I'm accessing this using serialIO from
> > > my application. and it was working fine with older EFI shell.
> > >
> > > Now I'm using the latest UEFI shell.
> > > Now It's working fine for first time. Then if i do any removal and
> > connect
> > > of serial port, there is a mismatch in "Handle index" value between the
> > one
> > > i get in my application, and the one i get in "sermode" command.
> > >
> > > I'm using the same code as sermode code, but still, for the same Handle
> > > value, the handleIndex value is deferring.
> > >
> > > Whether ConvertHandleIndexToHandle and
> ConvertHandleToHandleIndex
> > > functions
> > > are giving issue? What could be the reason?
> > >
> > > Thanks again.
> > > Regards,
> > > Keshava
> > > _______________________________________________
> > > edk2-devel mailing list
> > > edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
> > > https://lists.01.org/mailman/listinfo/edk2-devel
> >
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
> https://lists.01.org/mailman/listinfo/edk2-devel

      reply	other threads:[~2017-06-06 21:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-06 10:20 Issue in ConvertHandleIndexToHandle and ConvertHandleToHandleIndex GN Keshava
2017-06-06 15:45 ` Carsey, Jaben
2017-06-06 16:12   ` GN Keshava
2017-06-06 16:15     ` Carsey, Jaben
2017-06-06 16:32       ` GN Keshava
2017-06-06 21:06         ` Carsey, Jaben [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CB6E33457884FA40993F35157061515C6CAA8EC1@FMSMSX103.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox