From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 06B7421967BD7 for ; Tue, 6 Jun 2017 14:36:04 -0700 (PDT) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jun 2017 14:37:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,308,1493708400"; d="scan'208";a="977574697" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga003.jf.intel.com with ESMTP; 06 Jun 2017 14:37:10 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 6 Jun 2017 14:37:01 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.37]) by FMSMSX155.amr.corp.intel.com ([169.254.5.48]) with mapi id 14.03.0319.002; Tue, 6 Jun 2017 14:37:01 -0700 From: "Carsey, Jaben" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH] ShellPkg/alias: Return status for alias deletion Thread-Index: AQHS3p8Exk5HhSbxWku6n60zsJGWzaIX+hmAgADVCoD//42SsA== Date: Tue, 6 Jun 2017 21:37:00 +0000 Message-ID: References: <20170606082904.195040-1-ruiyu.ni@intel.com>, <734D49CCEBEEF84792F5B80ED585239D5B988FB6@SHSMSX104.ccr.corp.intel.com> <3DAAB008-D40F-48B1-B8AA-0F418CA19FE3@intel.com> In-Reply-To: <3DAAB008-D40F-48B1-B8AA-0F418CA19FE3@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTQ2MDQ0MGYtYzcyYy00YzlhLTk2MTctNGQ3ZTk2MDFlNDRjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImNaSFwvV3d1bHdSUkRtdUduN2lDVE1wQ002ZW1HVzJyWUlMYU1pOERoZkUwPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg/alias: Return status for alias deletion X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jun 2017 21:36:04 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable I am good with more clear error information coming to the user. Reviewed-by: Jaben Carsey > -----Original Message----- > From: Ni, Ruiyu > Sent: Tuesday, June 06, 2017 2:26 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Tapan Shah ; Carsey, Jaben > > Subject: Re: [edk2] [PATCH] ShellPkg/alias: Return status for alias delet= ion > Importance: High >=20 > Including Jaben for review. >=20 > Send from mobile phone >=20 > > =1B$B:_=1B(B 2017=1B$BG/=1B(B6=1B$B7n=1B(B6=1B$BF|!$2<8a=1B(B4:43=1B$B!= $=1B(BNi, Ruiyu =1B$B > > > Including Tapan. > > > > Thanks/Ray > > > >> -----Original Message----- > >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Ruiyu > >> Ni > >> Sent: Tuesday, June 6, 2017 4:29 PM > >> To: edk2-devel@lists.01.org > >> Subject: [edk2] [PATCH] ShellPkg/alias: Return status for alias deleti= on > >> > >> Contributed-under: TianoCore Contribution Agreement 1.0 > >> Signed-off-by: Ruiyu Ni > >> Cc: Tapan Shah > >> --- > >> ShellPkg/Library/UefiShellLevel3CommandsLib/Alias.c | 11 ++++++++++- > >> 1 file changed, 10 insertions(+), 1 deletion(-) > >> > >> diff --git a/ShellPkg/Library/UefiShellLevel3CommandsLib/Alias.c > >> b/ShellPkg/Library/UefiShellLevel3CommandsLib/Alias.c > >> index 5a3b7e5913..7277bd4b90 100644 > >> --- a/ShellPkg/Library/UefiShellLevel3CommandsLib/Alias.c > >> +++ b/ShellPkg/Library/UefiShellLevel3CommandsLib/Alias.c > >> @@ -2,7 +2,7 @@ > >> Main file for Alias shell level 3 function. > >> > >> (C) Copyright 2015 Hewlett-Packard Development Company, L.P.
> >> - Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved. =
> >> + Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved. > >> +
> >> This program and the accompanying materials > >> are licensed and made available under the terms and conditions of th= e > BSD > >> License > >> which accompanies this distribution. The full text of the license m= ay be > found > >> at @@ -151,6 +151,15 @@ ShellCommandRunAlias ( > >> // delete an alias > >> // > >> Status =3D gEfiShellProtocol->SetAlias(Param1, NULL, TRUE, FALSE= ); > >> + if (EFI_ERROR(Status)) { > >> + if (Status =3D=3D EFI_ACCESS_DENIED) { > >> + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_AD)= , > >> gShellLevel3HiiHandle, L"alias"); > >> + ShellStatus =3D SHELL_ACCESS_DENIED; > >> + } else { > >> + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_UK)= , > >> gShellLevel3HiiHandle, L"alias", Status); > >> + ShellStatus =3D SHELL_DEVICE_ERROR; > >> + } > >> + } > >> } else if (ShellCommandLineGetCount(Package) =3D=3D 3) { > >> // > >> // must be adding an alias > >> -- > >> 2.12.2.windows.2 > >> > >> _______________________________________________ > >> edk2-devel mailing list > >> edk2-devel@lists.01.org > >> https://lists.01.org/mailman/listinfo/edk2-devel