From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] ShellPkg: Remove unnecessary Readme.txt
Date: Wed, 7 Jun 2017 15:47:36 +0000 [thread overview]
Message-ID: <CB6E33457884FA40993F35157061515C6CAA93E3@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <20170607055158.415736-1-ruiyu.ni@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Tuesday, June 06, 2017 10:52 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>
> Subject: [edk2] [PATCH] ShellPkg: Remove unnecessary Readme.txt
> Importance: High
>
> The Readme.txt contains instructions about how to integrate Shell
> into Nt32. Actually Nt32 already contains a macro USE_OLD_SHELL to
> choose OLD or NEW Shell.
>
> So remove this txt file.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> ---
> ShellPkg/Readme.txt | 29 -----------------------------
> 1 file changed, 29 deletions(-)
> delete mode 100644 ShellPkg/Readme.txt
>
> diff --git a/ShellPkg/Readme.txt b/ShellPkg/Readme.txt
> deleted file mode 100644
> index 77841c0a2a..0000000000
> --- a/ShellPkg/Readme.txt
> +++ /dev/null
> @@ -1,29 +0,0 @@
> -
> ==========================================================
> ==================
> - OVERVIEW
> -
> ==========================================================
> ==================
> -The UEFI 2.0 shell provides a standard pre-boot command line processor.
> -It is similar to the EDK EFI Shell or a *nix command line parser.
> -
> -
> ==========================================================
> ==================
> - HOW TO INCORPORATE THIS SHELL INTO NT32
> -
> ==========================================================
> ==================
> -The instructions below are included as a sample and template on how a
> -developer may integrate this code into an existing platform:
> -
> -1. Add this shell build to the NT32 build:
> - Add the shell.inf to the [components] section as it is in the ShellPkg.dsc.
> -
> -2. Update system PCDs to support this new module
> - Update the PCD as follows using the Shell's PCD:
> - gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5,
> 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4,
> 0xD1 }
> -
> -3. Remove the old shell from the NT32 Firmware list
> - Remove the FILE APPLICATION section for the old shell.
> -
> -4. Add this shell to the NT32 firmware list
> - Add the Shell.INF to the end of the list of DXE modules.
> -
> -5. Build NT32
> -
> -
> -
> ==========================================================
> ==================
> --
> 2.12.2.windows.2
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2017-06-07 15:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 5:51 [PATCH] ShellPkg: Remove unnecessary Readme.txt Ruiyu Ni
2017-06-07 15:47 ` Carsey, Jaben [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB6E33457884FA40993F35157061515C6CAA93E3@FMSMSX103.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox