public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Shah, Tapan" <tapandshah@hpe.com>,
	"Hegde, Nagaraj P" <nagaraj-p.hegde@hpe.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
	"Fu, Siyuan" <siyuan.fu@intel.com>,
	"Wu, Jiaxin" <jiaxin.wu@intel.com>
Subject: Re: [PATCH v1 1/1] ShellPkg/ifconfig: Update help message
Date: Thu, 8 Jun 2017 15:59:53 +0000	[thread overview]
Message-ID: <CB6E33457884FA40993F35157061515C6CAAAEE1@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <CS1PR84MB0024D1196ACE9C71EBE3C0D6D4C90@CS1PR84MB0024.NAMPRD84.PROD.OUTLOOK.COM>

Seems quite straight forward to me.
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Shah, Tapan
> Sent: Thursday, June 08, 2017 8:55 AM
> To: Hegde, Nagaraj P <nagaraj-p.hegde@hpe.com>; edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu
> <ruiyu.ni@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin
> <jiaxin.wu@intel.com>
> Subject: Re: [edk2] [PATCH v1 1/1] ShellPkg/ifconfig: Update help message
> Importance: High
> 
> Reviewed-by: Tapan Shah <tapandshah@hpe.com>
> 
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Hegde, Nagaraj P
> Sent: Thursday, June 08, 2017 1:41 AM
> To: edk2-devel@lists.01.org
> Cc: jaben.carsey@intel.com; ruiyu.ni@intel.com; siyuan.fu@intel.com;
> jiaxin.wu@intel.com
> Subject: [edk2] [PATCH v1 1/1] ShellPkg/ifconfig: Update help message
> 
> Couple of instances had IP4 mentioned, instead of IPv4.
> Changing all to IPv4 to maintain consistency.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Hegde Nagaraj P <nagaraj-p.hegde@hpe.com>
> ---
> 
> ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Comm
> andsLib.uni | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.uni
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.uni
> index d9bbb209cd..d427dd209f 100644
> ---
> a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.uni
> +++
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.uni
> @@ -150,13 +150,13 @@
>  ".SH DESCRIPTION\r\n"
>  " \r\n"
>  "NOTES:\r\n"
> -"  1. This command modifies the default IP address for the UEFI IP4\r\n"
> +"  1. This command modifies the default IP address for the UEFI IPv4\r\n"
>  "     network stack.\r\n"
>  "  2. Use '-r' to renew configuration of interface and set dhcp policy.\r\n"
>  "  3. Use '-l' to list the DNS and other address related settings for all\r\n"
>  "     interfaces or the specified interface.\r\n"
>  "  4. Use '-s <Name> static <IP> <SubnetMask> <GatewayMask>' with \r\n"
> -"     static IP4 address configuration for specified interface.\r\n"
> +"     static IPv4 address configuration for specified interface.\r\n"
>  "  5. Use '-s <Name> dhcp' for DHCP4 to request the IP4 address\r\n"
>  "     configuration dynamically for specified interface.\r\n"
>  "  6. Use '-s <Name> dns <IP>' must under manual policy.\r\n"
> --
> 2.13.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2017-06-08 15:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-08  6:40 [PATCH v1 1/1] ShellPkg/ifconfig: Update help message hegdenag
2017-06-08 15:55 ` Shah, Tapan
2017-06-08 15:59   ` Carsey, Jaben [this message]
2017-06-09  0:58 ` Wu, Jiaxin
2017-06-09  7:27 ` Subramanian, Sriram

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CB6E33457884FA40993F35157061515C6CAAAEE1@FMSMSX103.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox