From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D07F621A6F106 for ; Thu, 8 Jun 2017 08:58:46 -0700 (PDT) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jun 2017 08:59:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,315,1493708400"; d="scan'208";a="112024585" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga005.fm.intel.com with ESMTP; 08 Jun 2017 08:59:55 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 8 Jun 2017 08:59:54 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.37]) by FMSMSX114.amr.corp.intel.com ([10.18.116.8]) with mapi id 14.03.0319.002; Thu, 8 Jun 2017 08:59:53 -0700 From: "Carsey, Jaben" To: "Shah, Tapan" , "Hegde, Nagaraj P" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Fu, Siyuan" , "Wu, Jiaxin" Thread-Topic: [edk2] [PATCH v1 1/1] ShellPkg/ifconfig: Update help message Thread-Index: AQHS4CIzgSk5YhgJQkOZf8BahlooVqIblFWA//+L47A= Date: Thu, 8 Jun 2017 15:59:53 +0000 Message-ID: References: <20170608064053.21644-1-nagaraj-p.hegde@hpe.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDVmNDkwOTYtMzQxMC00MTQ5LWE4YTYtMmFlNmUxZWNkMWVkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImpvVVlzZklFaGpMazhhVmVNQnlIV0lnYUlCVjNBYTl3ejRTVUltYkFBMzg9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [PATCH v1 1/1] ShellPkg/ifconfig: Update help message X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jun 2017 15:58:47 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Seems quite straight forward to me. Reviewed-by: Jaben Carsey > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Shah, Tapan > Sent: Thursday, June 08, 2017 8:55 AM > To: Hegde, Nagaraj P ; edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ruiyu > ; Fu, Siyuan ; Wu, Jiaxin > > Subject: Re: [edk2] [PATCH v1 1/1] ShellPkg/ifconfig: Update help message > Importance: High >=20 > Reviewed-by: Tapan Shah >=20 > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Hegde, Nagaraj P > Sent: Thursday, June 08, 2017 1:41 AM > To: edk2-devel@lists.01.org > Cc: jaben.carsey@intel.com; ruiyu.ni@intel.com; siyuan.fu@intel.com; > jiaxin.wu@intel.com > Subject: [edk2] [PATCH v1 1/1] ShellPkg/ifconfig: Update help message >=20 > Couple of instances had IP4 mentioned, instead of IPv4. > Changing all to IPv4 to maintain consistency. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Hegde Nagaraj P > --- >=20 > ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Comm > andsLib.uni | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > mandsLib.uni > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > mandsLib.uni > index d9bbb209cd..d427dd209f 100644 > --- > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > mandsLib.uni > +++ > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > mandsLib.uni > @@ -150,13 +150,13 @@ > ".SH DESCRIPTION\r\n" > " \r\n" > "NOTES:\r\n" > -" 1. This command modifies the default IP address for the UEFI IP4\r\n" > +" 1. This command modifies the default IP address for the UEFI IPv4\r\n= " > " network stack.\r\n" > " 2. Use '-r' to renew configuration of interface and set dhcp policy.\= r\n" > " 3. Use '-l' to list the DNS and other address related settings for al= l\r\n" > " interfaces or the specified interface.\r\n" > " 4. Use '-s static ' with \r\n" > -" static IP4 address configuration for specified interface.\r\n" > +" static IPv4 address configuration for specified interface.\r\n" > " 5. Use '-s dhcp' for DHCP4 to request the IP4 address\r\n" > " configuration dynamically for specified interface.\r\n" > " 6. Use '-s dns ' must under manual policy.\r\n" > -- > 2.13.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel