From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: Tapan Shah <tapandshah@hpe.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>
Subject: Re: [PATCH] ShellPkg: Fix typo errors in ifconfig help output
Date: Fri, 9 Jun 2017 18:03:21 +0000 [thread overview]
Message-ID: <CB6E33457884FA40993F35157061515C7524DDE3@fmsmsx101.amr.corp.intel.com> (raw)
In-Reply-To: <1497028281-14992-1-git-send-email-tapandshah@hpe.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: Tapan Shah [mailto:tapandshah@hpe.com]
> Sent: Friday, June 09, 2017 10:11 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu
> <ruiyu.ni@intel.com>; Tapan Shah <tapandshah@hpe.com>
> Subject: [PATCH] ShellPkg: Fix typo errors in ifconfig help output
> Importance: High
>
> Found few instances where IPv4 and DHCPv4 spelled incorrectly
> as IP4 and DHCP4 respectively.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Tapan Shah <tapandshah@hpe.com>
> ---
> .../UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.uni
> | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.uni
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.uni
> index edadcc5..70c3465 100644
> ---
> a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.uni
> +++
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.uni
> @@ -2,6 +2,7 @@
> //
> // (C) Copyright 2013-2015 Hewlett-Packard Development Company,
> L.P.<BR>
> // Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved. <BR>
> +// (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR>
> // This program and the accompanying materials
> // are licensed and made available under the terms and conditions of the
> BSD License
> // which accompanies this distribution. The full text of the license may be
> found at
> @@ -157,7 +158,7 @@
> " interfaces or the specified interface.\r\n"
> " 4. Use '-s <Name> static <IP> <SubnetMask> <GatewayMask>' with \r\n"
> " static IPv4 address configuration for specified interface.\r\n"
> -" 5. Use '-s <Name> dhcp' for DHCP4 to request the IP4 address\r\n"
> +" 5. Use '-s <Name> dhcp' for DHCPv4 to request the IPv4 address\r\n"
> " configuration dynamically for specified interface.\r\n"
> " 6. Use '-s <Name> dns <IP>' must under manual policy.\r\n"
> ".SH EXAMPLES\r\n"
> @@ -166,7 +167,7 @@
> " * To list the configuration for the eth0 interface:\r\n"
> " fs0:\> ifconfig -l eth0\r\n"
> " \r\n"
> -" * To use DHCP4 to request the IPv4 address configuration dynamically for
> the\r\n"
> +" * To use DHCPv4 to request the IPv4 address configuration dynamically
> for the\r\n"
> " eth0 interface:\r\n"
> " fs0:\> ifconfig -s eth0 dhcp\r\n"
> " \r\n"
> --
> 1.9.5.msysgit.0
prev parent reply other threads:[~2017-06-09 18:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 17:11 [PATCH] ShellPkg: Fix typo errors in ifconfig help output Tapan Shah
2017-06-09 18:03 ` Carsey, Jaben [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB6E33457884FA40993F35157061515C7524DDE3@fmsmsx101.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox